Skip to content

chore: adjust debug logs for updating a dependent resource #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

chore: adjust debug logs for updating a dependent resource #2428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,17 @@ protected ReconcileResult<R> reconcile(P primary, R actualResource, Context<P> c
logForOperation("Updating", primary, desired);
var updatedResource = handleUpdate(actualResource, desired, primary, context);
return ReconcileResult.resourceUpdated(updatedResource);
} else {
log.debug("Update skipped for dependent {} as it matched the existing one",
actualResource instanceof HasMetadata
? ResourceID.fromResource((HasMetadata) actualResource)
: getClass().getSimpleName());
}
} else {
log.debug("Update skipped for dependent {} as it matched the existing one",
actualResource);
log.debug("Update skipped for dependent {} implement Updater interface to modify it",
actualResource instanceof HasMetadata
? ResourceID.fromResource((HasMetadata) actualResource)
: getClass().getSimpleName());
}
}
} else {
Expand Down