improve: samples correctly create status object for SSA #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
reviewed
Apr 25, 2024
| private MySQLSchema createForStatusUpdate(MySQLSchema mySQLSchema, Schema schema, | ||
| String secretName, | ||
| String userName) { | ||
| MySQLSchema res = new MySQLSchema(); |
Collaborator
There was a problem hiding this comment.
To be honest, having to do that for SSA is quite annoying… I'm wondering if there's anything we can do about it…
Collaborator
Author
There was a problem hiding this comment.
Yeah, not sure, maybe an utility to clone a shallow class? this results certainly in a kind of a boilerplate code .
metacosm
approved these changes
Apr 25, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Jul 8, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Jul 9, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 8, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 19, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Attila Mészáros <[email protected]>
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.