Skip to content

improve: logging for informers #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2023
Merged

improve: logging for informers #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20410db
improve: logging for informers
csviri Feb 3, 2023
b155683
format
csviri Feb 3, 2023
6012ff1
fix: extra quote
metacosm Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...k-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,14 @@ public synchronized void stop() {
@SuppressWarnings("rawtypes")
private void logEventSourceEvent(NamedEventSource eventSource, String event) {
if (log.isDebugEnabled()) {
if (eventSource instanceof ResourceEventSource) {
ResourceEventSource source = (ResourceEventSource) eventSource;
log.debug("{} event source {} for {}", event, eventSource.name(),
if (eventSource.original() instanceof ResourceEventSource) {
ResourceEventSource source = (ResourceEventSource) eventSource.original();
log.debug("{} event source {} for {}", event,
eventSource.isNameSet() ? eventSource.name() : eventSource,
source.resourceType());
} else {
log.debug("{} event source {}", event, eventSource.name());
log.debug("{} event source {}", event,
eventSource.isNameSet() ? eventSource.name() : eventSource);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ork-core/src/main/java/io/javaoperatorsdk/operator/processing/event/NamedEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public EventSource eventSource() {

@Override
public String toString() {
return original + " named: '" + name + "'}";
return original + " named: " + name;
}

public EventSource original() {
Expand Down