Skip to content

improve: logging for informer health check #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

improve: logging for informer health check #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...mework-core/src/main/java/io/javaoperatorsdk/operator/health/InformerHealthIndicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ public interface InformerHealthIndicator extends EventSourceHealthIndicator {
boolean isRunning();

@Override
default Status getStatus() {
return isRunning() && hasSynced() && isWatching() ? Status.HEALTHY : Status.UNHEALTHY;
}
Status getStatus();

String getTargetNamespace();
}
11 changes: 11 additions & 0 deletions ...in/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import io.javaoperatorsdk.operator.ReconcilerUtils;
import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
import io.javaoperatorsdk.operator.health.InformerHealthIndicator;
import io.javaoperatorsdk.operator.health.Status;
import io.javaoperatorsdk.operator.processing.LifecycleAware;
import io.javaoperatorsdk.operator.processing.event.ResourceID;
import io.javaoperatorsdk.operator.processing.event.source.IndexerResourceCache;
Expand Down Expand Up @@ -175,6 +176,16 @@ public boolean isRunning() {
return informer.isRunning();
}

@Override
public Status getStatus() {
var status = isRunning() && hasSynced() && isWatching() ? Status.HEALTHY : Status.UNHEALTHY;
log.debug(
"Informer status: {} for for type: {}, namespace: {}, details[ is running: {}, has synced: {}, is watching: {} ]",
status, informer.getApiTypeClass().getSimpleName(), namespaceIdentifier, isRunning(),
hasSynced(), isWatching());
return status;
}

@Override
public String getTargetNamespace() {
return namespaceIdentifier;
Expand Down