Skip to content

update broken internal links #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

maxistar
Copy link
Contributor

@maxistar maxistar commented Jun 19, 2025

in this PR I want to fix warnings about broken links during compile time.
some pages were not existing so I have created empty index files for such cases.

now when we run "npm start" only one broken link is detected about missing update/minor/721-to-722/index.md which I did not find.

There are some warnings about unsupported image types which should be fixed separately.

I did not fix broken links in HTML code - such fixes will be not detected by compiler so there is no way to make sure it is actually fixed. We can do it if implement link checker.

this PR partially fixes #3. Since this PR is very big, the follow up PR will be created when this one will be merged.

@a-m-zill a-m-zill self-requested a review June 21, 2025 22:32
@a-m-zill
Copy link
Contributor

Thank you @maxistar, i will check this.

@javahippie
Copy link
Contributor

Thanks a lot, does this relate to #3? If so, a mention in the PR comment would link it properly

@maxistar
Copy link
Contributor Author

maxistar commented Jun 23, 2025

Thanks a lot, does this relate to #3? If so, a mention in the PR comment would link it properly

yes, it is related it #3 I discovered though that there are two kind of links - markdown and html. This PR is fixing markdown links. Docusaurus can complain when these links are broken. The pure html links even if they are broken are not being checked during the compilation time. I checked different tools and found some ways to check these also. When we merge this PR I will prepare an another PR to fix html links too.

Copy link
Contributor

@a-m-zill a-m-zill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxistar,

thx for your work. I have a few comments for you. When you have any question to me, ping me here or in slack.

Thx,
Andreas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxistar,
i am now on the review and this file is wrong, because we not support "IBM WebSphere Application Server" any more. I think in C7 it was onlye for Enterprise Customers. I think you have added this file because of another reference on it. Can you update your PR and remove this file and clean the reference, please.

When i get something wrong, let me know.

Thx,
Andreas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxistar,

here the same like it is with the was/index.md file for "IBM WebSphere Application Server".

Thx,
Andreas

@@ -35,7 +35,7 @@ Run Operaton in every Java-runnable environment. Operaton is supported with our
* Apache Tomcat 9.0 / 10.1
* JBoss EAP 7.4 / 8.0
* WildFly Application Server 23.0 / 26.0 / 33.0
see [Installation guide](../installation/full/was/manual-liberty.md))
see [Installation guide](../installation/full/was/index.md))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here please change was/index.md for wildfly/index.md.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* [IBM WebSphere Application Server](../installation/full/was/index.md)
* [Oracle WebLogic Application Server](../installation/full/wls/index.md)
* [Apache Tomcat](../../../installation/full/tomcat/index.md)
* [IBM WebSphere Application Server](../../../installation/full/was/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* [Oracle WebLogic Application Server](../installation/full/wls/index.md)
* [Apache Tomcat](../../../installation/full/tomcat/index.md)
* [IBM WebSphere Application Server](../../../installation/full/was/index.md)
* [Oracle WebLogic Application Server](../../../installation/full/wls/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line also can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* [IBM WebSphere Application Server](../installation/full/was/index.md)
* [Oracle WebLogic Application Server](../installation/full/wls/index.md)
* [Apache Tomcat](../../../installation/full/tomcat/index.md)
* [IBM WebSphere Application Server](../../../installation/full/was/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* [Oracle WebLogic Application Server](../installation/full/wls/index.md)
* [Apache Tomcat](../../../installation/full/tomcat/index.md)
* [IBM WebSphere Application Server](../../../installation/full/was/index.md)
* [Oracle WebLogic Application Server](../../../installation/full/wls/index.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -172,7 +172,7 @@ With `local="true"` for the `in` mapping, only `var2` is mapped into the called

# Pass Business Key

In addition to [exchanging variables](../reference/cmmn11/tasks/case-task.md#exchange-variables), it is possible to pass a business key to the called case instance as well. Since a business key is immutable, this is one way mapping. It is not possible to have output mapping for a business key.
In addition to [exchanging variables](../tasks/case-task.md#exchange-variables), it is possible to pass a business key to the called case instance as well. Since a business key is immutable, this is one way mapping. It is not possible to have output mapping for a business key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it here not be enough to write case-task.md#exchange-variables? Because we are in the same file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, updated.

@kthoms kthoms requested a review from a-m-zill August 1, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken internal links
4 participants