Beta/0.13.0

.github/workflows/example_build.yml

@@ -10,7 +10,7 @@ on:
 env:
   nodeVersion: "16"
   cmakeVersion: "3.22.x"
-  flutterVersion: "3.0.4"
+  flutterVersion: "3.0.5"
 
 jobs:
   build_android-app_in_macos:

.github/workflows/integration_test_flutter.yml

@@ -5,7 +5,7 @@ on: [workflow_dispatch, pull_request]
 env:
   nodeVersion: "16"
   cmakeVersion: "3.22.x"
-  flutterVersion: "3.0.4"
+  flutterVersion: "3.0.5"
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
@@ -30,7 +30,7 @@ jobs:
       with:
         cmake-version: ${{ env.cmakeVersion }}
     - run: npm i
-    - run: ENABLE_ASAN=true npm run build:bridge:macos
+    - run: npm run build:bridge:macos
     - uses: actions/upload-artifact@v2
       with:
         name: macos_bridge_binary
@@ -49,22 +49,6 @@ jobs:
     - run: npm i
     - run: ENABLE_ASAN=true npm run build:bridge:linux
     - run: node scripts/run_bridge_unit_test.js
-      id: bridge_test
-    - name: Check on failures
-      if: steps.bridge_test.outcome == 'success'
-      run: exit 0
-    - run: sudo chmod -R +rwx /cores/* # Enable access to core dumps
-    - run: ulimit -c               # should output 0 if disabled
-    - run: ulimit -c unlimited
-    - run: ulimit -c               # should output 'unlimited' now
-    - run: sudo touch /cores/test
-    - run: ls /cores
-    - run: sudo rm /cores/test
-    - uses: actions/upload-artifact@master # capture all crashes as build artifacts
-      if: steps.bridge_test.outcome != 'success'
-      with:
-        name: crashes
-        path: /cores
 
   webf_unit_test:
     runs-on: ubuntu-latest

bridge/CMakeLists.txt

@@ -59,10 +59,15 @@ if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
 endif()
 
 if (ENABLE_ASAN)
-  add_compile_options(-fsanitize=address -fno-omit-frame-pointer -O1)
+  add_compile_options(-fsanitize=address -fno-omit-frame-pointer)
   add_link_options(-fsanitize=address -fno-omit-frame-pointer)
 endif ()
 
+if (${CMAKE_BUILD_TYPE} STREQUAL "Debug")
+  # Avoid quickjs stackoverflow.
+  add_compile_options(-O1)
+endif()
+
 if (DEFINED PLATFORM)
   if (${PLATFORM} STREQUAL "OS")
     add_compile_options(-fno-aligned-allocation)
@@ -194,6 +199,7 @@ if ($ENV{WEBF_JS_ENGINE} MATCHES "quickjs")
     core/executing_context.cc
     core/script_state.cc
     core/page.cc
+    core/dart_methods.cc
     core/executing_context_data.cc
     core/fileapi/blob.cc
     core/fileapi/blob_part.cc
@@ -270,6 +276,7 @@ if ($ENV{WEBF_JS_ENGINE} MATCHES "quickjs")
     core/html/html_anchor_element.cc
     core/html/html_image_element.cc
     core/html/html_script_element.cc
+    core/html/html_link_element.cc
     core/html/html_unknown_element.cc
     core/html/image.cc
     core/html/canvas/html_canvas_element.cc
@@ -362,6 +369,7 @@ if ($ENV{WEBF_JS_ENGINE} MATCHES "quickjs")
     out/qjs_html_html_element.cc
     out/qjs_html_image_element.cc
     out/qjs_html_canvas_element.cc
+    out/qjs_html_link_element.cc
     out/qjs_image.cc
     out/qjs_widget_element.cc
     out/qjs_canvas_rendering_context_2d.cc
@@ -386,6 +394,8 @@ if ($ENV{WEBF_JS_ENGINE} MATCHES "quickjs")
     out/html_element_factory.cc
     out/html_names.cc
     out/script_type_names.cc
+    out/defined_properties.cc
+    out/defined_properties_initializer.cc
     out/element_attribute_names.cc
     )
 

bridge/bindings/qjs/binding_initializer.cc

@@ -37,6 +37,7 @@
 #include "qjs_html_html_element.h"
 #include "qjs_html_image_element.h"
 #include "qjs_html_input_element.h"
+#include "qjs_html_link_element.h"
 #include "qjs_html_script_element.h"
 #include "qjs_html_template_element.h"
 #include "qjs_html_textarea_element.h"
@@ -119,6 +120,7 @@ void InstallBindings(ExecutingContext* context) {
   QJSHTMLButtonElement::Install(context);
   QJSImage::Install(context);
   QJSHTMLScriptElement::Install(context);
+  QJSHTMLLinkElement::Install(context);
   QJSHTMLUnknownElement::Install(context);
   QJSHTMLTemplateElement::Install(context);
   QJSHTMLCanvasElement::Install(context);

bridge/bindings/qjs/cppgc/mutation_scope.cc

@@ -4,6 +4,7 @@
  */
 
 #include "mutation_scope.h"
+#include "bindings/qjs/script_wrappable.h"
 #include "core/executing_context.h"
 
 namespace webf {

bridge/bindings/qjs/js_based_event_listener.cc

@@ -14,7 +14,7 @@ void JSBasedEventListener::Invoke(ExecutingContext* context, Event* event, Excep
   assert(context);
   assert(event);
 
-  if (!context->IsValid())
+  if (!context->IsContextValid())
     return;
   // Step 10: Call a listener with event's currentTarget as receiver and event
   // and handle errors if thrown.

bridge/bindings/qjs/js_based_event_listener.h

@@ -9,6 +9,7 @@
 #include <quickjs/quickjs.h>
 #include "core/dom/events/event_listener.h"
 #include "core/executing_context.h"
+#include "foundation/casting.h"
 
 namespace webf {
 

bridge/bindings/qjs/rejected_promises.cc

@@ -4,6 +4,7 @@
  */
 
 #include "rejected_promises.h"
+#include "bindings/qjs/cppgc/mutation_scope.h"
 #include "core/executing_context.h"
 
 namespace webf {

bridge/bindings/qjs/script_promise_resolver.h

@@ -60,7 +60,7 @@ class ScriptPromiseResolver {
   }
 
   void ResolveOrReject(JSValue value, ResolutionState new_state) {
-    if (state_ != kPending || !context_->IsValid() || !context_)
+    if (state_ != kPending || !context_->IsContextValid() || !context_)
       return;
     assert(new_state == kResolving || new_state == kRejecting);
     state_ = new_state;

bridge/bindings/qjs/script_value.cc

@@ -147,7 +147,7 @@ AtomicString ScriptValue::ToString() const {
   return {ctx_, value_};
 }
 
-NativeValue ScriptValue::ToNative() const {
+NativeValue ScriptValue::ToNative(ExceptionState& exception_state) const {
   int8_t tag = JS_VALUE_GET_TAG(value_);
 
   switch (tag) {
@@ -175,15 +175,15 @@ NativeValue ScriptValue::ToNative() const {
             Converter<IDLSequence<IDLAny>>::FromValue(ctx_, value_, ASSERT_NO_EXCEPTION());
         auto* result = new NativeValue[values.size()];
         for (int i = 0; i < values.size(); i++) {
-          result[i] = values[i].ToNative();
+          result[i] = values[i].ToNative(exception_state);
         }
         return Native_NewList(values.size(), result);
       } else if (JS_IsObject(value_)) {
         if (QJSEventTarget::HasInstance(ExecutingContext::From(ctx_), value_)) {
           auto* event_target = toScriptWrappable<EventTarget>(value_);
           return Native_NewPtr(JSPointerType::Others, event_target->bindingObject());
         }
-        return NativeValueConverter<NativeTypeJSON>::ToNativeValue(*this);
+        return NativeValueConverter<NativeTypeJSON>::ToNativeValue(*this, exception_state);
       }
     }
     default:

bridge/bindings/qjs/script_value.h

@@ -60,7 +60,7 @@ class ScriptValue final {
   // Create a new ScriptValue from call JSON.stringify to current value.
   ScriptValue ToJSONStringify(ExceptionState* exception) const;
   AtomicString ToString() const;
-  NativeValue ToNative() const;
+  NativeValue ToNative(ExceptionState& exception_state) const;
 
   bool IsException() const;
   bool IsEmpty() const;

bridge/bindings/qjs/script_wrappable.cc

@@ -75,6 +75,41 @@ static int HandleJSPropertySetterCallback(JSContext* ctx,
   auto* object = static_cast<ScriptWrappable*>(JS_GetOpaque(obj, JSValueGetClassId(obj)));
   auto* wrapper_type_info = object->GetWrapperTypeInfo();
 
+  ExecutingContext* context = ExecutingContext::From(ctx);
+  JSValue prototypeObject = context->contextData()->prototypeForType(wrapper_type_info);
+  if (JS_HasProperty(ctx, prototypeObject, atom)) {
+    JSValue target = JS_DupValue(ctx, prototypeObject);
+    JSValue setterFunc = JS_UNDEFINED;
+    while (JS_IsUndefined(setterFunc)) {
+      JSPropertyDescriptor descriptor;
+      descriptor.setter = JS_UNDEFINED;
+      descriptor.getter = JS_UNDEFINED;
+      descriptor.value = JS_UNDEFINED;
+      JS_GetOwnProperty(ctx, &descriptor, target, atom);
+      setterFunc = descriptor.setter;
+      if (JS_IsFunction(ctx, setterFunc)) {
+        JS_FreeValue(ctx, descriptor.getter);
+        break;
+      }
+
+      JSValue new_target = JS_GetPrototype(ctx, target);
+      JS_FreeValue(ctx, target);
+      target = new_target;
+      JS_FreeValue(ctx, descriptor.getter);
+      JS_FreeValue(ctx, descriptor.setter);
+    }
+
+    assert_m(JS_IsFunction(ctx, setterFunc), "Setter on prototype should be an function.");
+    JSValue ret = JS_Call(ctx, setterFunc, obj, 1, &value);
+    if (JS_IsException(ret))
+      return -1;
+
+    JS_FreeValue(ctx, ret);
+    JS_FreeValue(ctx, setterFunc);
+    JS_FreeValue(ctx, target);
+    return 0;
+  }
+
   if (wrapper_type_info->indexed_property_setter_handler_ != nullptr && JS_AtomIsTaggedInt(atom)) {
     return wrapper_type_info->indexed_property_setter_handler_(ctx, obj, JS_AtomToUInt32(atom), value);
   } else if (wrapper_type_info->string_property_setter_handler_ != nullptr) {
@@ -165,6 +200,8 @@ void ScriptWrappable::InitializeQuickJSObject() {
           if (!JS_IsNull(return_value)) {
             desc->flags = JS_PROP_ENUMERABLE;
             desc->value = return_value;
+            desc->getter = JS_NULL;
+            desc->setter = JS_NULL;
             return true;
           }
         }
@@ -175,6 +212,8 @@ void ScriptWrappable::InitializeQuickJSObject() {
           if (!JS_IsNull(return_value)) {
             desc->flags = JS_PROP_ENUMERABLE;
             desc->value = return_value;
+            desc->getter = JS_NULL;
+            desc->setter = JS_NULL;
             return true;
           }
         }

bridge/bindings/qjs/script_wrappable.h

@@ -8,6 +8,7 @@
 
 #include <quickjs/quickjs.h>
 #include "bindings/qjs/cppgc/garbage_collected.h"
+#include "core/executing_context.h"
 #include "foundation/macros.h"
 #include "wrapper_type_info.h"
 

bridge/bindings/qjs/wrapper_type_info.h

@@ -65,6 +65,7 @@ enum {
   JS_CLASS_HTML_IMAGE_ELEMENT,
   JS_CLASS_HTML_SCRIPT_ELEMENT,
   JS_CLASS_HTML_ANCHOR_ELEMENT,
+  JS_CLASS_HTML_LINK_ELEMENT,
   JS_CLASS_HTML_CANVAS_ELEMENT,
   JS_CLASS_IMAGE,
   JS_CLASS_CANVAS_RENDERING_CONTEXT,

bridge/core/binding_call_methods.json5

@@ -150,6 +150,8 @@
     "getElementsByName",
     "getElementsByTagName",
     "id",
-    "className"
+    "className",
+    "cookie",
+    "class"
   ]
 }

bridge/core/binding_object.cc

@@ -25,7 +25,11 @@ void NativeBindingObject::HandleCallFromDartSide(NativeBindingObject* binding_ob
 
 BindingObject::BindingObject(ExecutingContext* context) : context_(context) {}
 BindingObject::~BindingObject() {
-  delete binding_object_;
+  // Set below properties to nullptr to avoid dart callback to native.
+  binding_object_->disposed_ = true;
+  binding_object_->binding_target_ = nullptr;
+  binding_object_->invoke_binding_methods_from_dart = nullptr;
+  binding_object_->invoke_bindings_methods_from_native = nullptr;
 }
 
 BindingObject::BindingObject(ExecutingContext* context, NativeBindingObject* native_binding_object)
@@ -101,20 +105,24 @@ ScriptValue BindingObject::AnonymousFunctionCallback(JSContext* ctx,
 
   std::vector<NativeValue> arguments;
   arguments.reserve(argc + 1);
-
   arguments.emplace_back(NativeValueConverter<NativeTypeInt64>::ToNativeValue(id));
+
+  ExceptionState exception_state;
+
   for (int i = 0; i < argc; i++) {
-    arguments.emplace_back(argv[i].ToNative());
+    arguments.emplace_back(argv[i].ToNative(exception_state));
+  }
+
+  if (exception_state.HasException()) {
+    event_target->GetExecutingContext()->HandleException(exception_state);
+    return ScriptValue::Empty(ctx);
   }
 
-  ExceptionState exception_state;
   NativeValue result = event_target->InvokeBindingMethod(BindingMethodCallOperations::kAnonymousFunctionCall,
                                                          arguments.size(), arguments.data(), exception_state);
 
   if (exception_state.HasException()) {
-    JSValue error = JS_GetException(ctx);
-    event_target->GetExecutingContext()->ReportError(error);
-    JS_FreeValue(ctx, error);
+    event_target->GetExecutingContext()->HandleException(exception_state);
     return ScriptValue::Empty(ctx);
   }
   return ScriptValue(ctx, result);
@@ -125,7 +133,7 @@ void BindingObject::HandleAnonymousAsyncCalledFromDart(void* ptr,
                                                        int32_t contextId,
                                                        const char* errmsg) {
   auto* promise_context = static_cast<BindingObjectPromiseContext*>(ptr);
-  if (!promise_context->context->IsValid())
+  if (!promise_context->context->IsContextValid())
     return;
   if (promise_context->context->contextId() != contextId)
     return;
@@ -173,13 +181,20 @@ ScriptValue BindingObject::AnonymousAsyncFunctionCallback(JSContext* ctx,
   arguments.emplace_back(NativeValueConverter<NativeTypePointer<void>>::ToNativeValue(
       reinterpret_cast<void*>(HandleAnonymousAsyncCalledFromDart)));
 
+  ExceptionState exception_state;
+
   for (int i = 0; i < argc; i++) {
-    arguments.emplace_back(argv[i].ToNative());
+    arguments.emplace_back(argv[i].ToNative(exception_state));
   }
 
-  ExceptionState exception_state;
   event_target->InvokeBindingMethod(BindingMethodCallOperations::kAsyncAnonymousFunction, argc + 4, arguments.data(),
                                     exception_state);
+
+  if (exception_state.HasException()) {
+    event_target->GetExecutingContext()->HandleException(exception_state);
+    return ScriptValue::Empty(ctx);
+  }
+
   return promise_resolver->Promise().ToValue();
 }
 

bridge/core/binding_object.h

@@ -43,6 +43,7 @@ struct NativeBindingObject : public DartReadable {
                                      int32_t argc,
                                      NativeValue* argv);
 
+  bool disposed_{false};
   BindingObject* binding_target_{nullptr};
   InvokeBindingMethodsFromDart invoke_binding_methods_from_dart{nullptr};
   InvokeBindingsMethodsFromNative invoke_bindings_methods_from_native{nullptr};