fix: fix css lenght parse stack overflow with font: inherit property #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@looseyi can you provide the test cases about this bug fix? |
|
let me check how to add that |
andycall
approved these changes
Sep 12, 2023
XGHeaven
approved these changes
Nov 1, 2023
andycall
added a commit
that referenced
this pull request
Nov 16, 2023
…449) 2023-08-07 20:47:25.935739+0800 Runner[7889:8608870] flutter: Stack Overflow (dart:collection-patch/compact_hash.dart:601:3) (package:webf/src/css/style_declaration.dart:150:30) (package:webf/src/css/values/length.dart:590:68) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) ... (package:webf/src/dom/element.dart:1402:11) (package:webf/src/css/style_declaration.dart:685:22) (package:webf/src/css/style_declaration.dart:457:7) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/launcher/controller.dart:461:16) (package:webf/src/bridge/to_native.dart:469:5) (package:webf/src/bridge/to_native.dart:221:40) (dart:async/future_impl.dart:767:45) (dart:async/future_impl.dart:767:45) Co-authored-by: edmond.l <[email protected]> Co-authored-by: TIANCHENG <[email protected]>
andycall
added a commit
that referenced
this pull request
Nov 18, 2023
…449) 2023-08-07 20:47:25.935739+0800 Runner[7889:8608870] flutter: Stack Overflow (dart:collection-patch/compact_hash.dart:601:3) (package:webf/src/css/style_declaration.dart:150:30) (package:webf/src/css/values/length.dart:590:68) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) ... (package:webf/src/dom/element.dart:1402:11) (package:webf/src/css/style_declaration.dart:685:22) (package:webf/src/css/style_declaration.dart:457:7) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/launcher/controller.dart:461:16) (package:webf/src/bridge/to_native.dart:469:5) (package:webf/src/bridge/to_native.dart:221:40) (dart:async/future_impl.dart:767:45) (dart:async/future_impl.dart:767:45) Co-authored-by: edmond.l <[email protected]> Co-authored-by: TIANCHENG <[email protected]>
andycall
added a commit
that referenced
this pull request
Nov 22, 2023
…449) 2023-08-07 20:47:25.935739+0800 Runner[7889:8608870] flutter: Stack Overflow (dart:collection-patch/compact_hash.dart:601:3) (package:webf/src/css/style_declaration.dart:150:30) (package:webf/src/css/values/length.dart:590:68) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) (package:webf/src/css/values/length.dart:590:16) ... (package:webf/src/dom/element.dart:1402:11) (package:webf/src/css/style_declaration.dart:685:22) (package:webf/src/css/style_declaration.dart:457:7) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/dom/element.dart:1061:17) (package:webf/src/dom/element.dart:600:5) (package:webf/src/launcher/controller.dart:461:16) (package:webf/src/bridge/to_native.dart:469:5) (package:webf/src/bridge/to_native.dart:221:40) (dart:async/future_impl.dart:767:45) (dart:async/future_impl.dart:767:45) Co-authored-by: edmond.l <[email protected]> Co-authored-by: TIANCHENG <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-08-07 20:47:25.935739+0800 Runner[7889:8608870] flutter: Stack Overflow
#0 _LinkedHashMapMixin.[] (dart:collection-patch/compact_hash.dart:601:3)
#1 CSSStyleDeclaration.getPropertyValue (package:webf/src/css/style_declaration.dart:150:30)
#2 CSSLength.parseLength (package:webf/src/css/values/length.dart:590:68)
#3 CSSLength.parseLength (package:webf/src/css/values/length.dart:590:16)
#4 CSSLength.parseLength (package:webf/src/css/values/length.dart:590:16)
#5 CSSLength.parseLength (package:webf/src/css/values/length.dart:590:16)
...
#2116 Element.setRenderStyleProperty (package:webf/src/dom/element.dart:1402:11)
#2117 Element.setRenderStyle (package:webf/src/dom/element.dart:1777:5)
#2118 Element._onStyleChanged (package:webf/src/dom/element.dart:1849:7)
#2119 CSSStyleDeclaration._emitPropertyChanged (package:webf/src/css/style_declaration.dart:685:22)
#2120 CSSStyleDeclaration.flushPendingProperties (package:webf/src/css/style_declaration.dart:457:7)
#2121 Element.attachTo (package:webf/src/dom/element.dart:997:13)
#2122 Element.ensureChildAttached (package:webf/src/dom/element.dart:1061:17)
#2123 Element.didAttachRenderer (package:webf/src/dom/element.dart:600:5)
#2124 Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2125 Element.ensureChildAttached (package:webf/src/dom/element.dart:1061:17)
#2126 Element.didAttachRenderer (package:webf/src/dom/element.dart:600:5)
#2127 Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2128 Element.ensureChildAttached (package:webf/src/dom/element.dart:1061:17)
#2129 Element.didAttachRenderer (package:webf/src/dom/element.dart:600:5)
#2130 Element.attachTo (package:webf/src/dom/element.dart:999:7)
#2131 Element.appendChild (package:webf/src/dom/element.dart:1094:15)
#2132 WebFViewController.insertAdjacentNode (package:webf/src/launcher/controller.dart:461:16)
#2133 flushUICommand (package:webf/src/bridge/to_native.dart:524:16)
#2134 flushUICommandWithContextId (package:webf/src/bridge/to_native.dart:469:5)
#2135 _flushUICommand (package:webf/src/bridge/from_native.dart:371:3)
#2136 _FfiCallback_flushUICommand (dart:ffi)
#2137 FfiTrampoline__evaluateQuickjsByteCode (dart:ffi)
#2138 evaluateQuickjsByteCode (package:webf/src/bridge/to_native.dart:221:40)
#2139 evaluateScripts (package:webf/src/bridge/to_native.dart:166:19)
#2140 _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2141 _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#2142 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:767:45)
#2143 Future._propagateToListeners (dart:async/future_impl.dart:796:13)
#2144 Future._completeWithValue (dart:async/future_impl.dart:567:5)
#2145 _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2146 _FutureListener.handleValue (dart:async/future_impl.dart:147:18)
#2147 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:767:45)
#2148 Future._propagateToListeners (dart:async/future_impl.dart:796:13)
#2149 Future._completeWithValue (dart:async/future_impl.dart:567:5)
#2150 _RootZone.runUnary (dart:async/zone.dart:1660:54)
#2151 _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#2152 _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)