Skip to content

USB PD: Improve requesting fixed voltage function #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

USB PD: Improve requesting fixed voltage function #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libraries/USBPD_SINK/examples/usbpd_sink_request_voltage/usbpd_sink_request_voltage.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ void loop() {

if(usbpd_sink_get_ready())
{
usbpd_sink_set_request_fixed_voltage(setVoltage);
if(usbpd_sink_set_request_fixed_voltage(setVoltage) == false)
{
Serial.printf("unsupported voltage\r\n");
}
}

// button, myIndex++
Expand Down
7 changes: 4 additions & 3 deletions libraries/USBPD_SINK/src/usbpd_sink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void usbpd_sink_clear_ready(void)
pdControl_g.cc_USBPD_READY = 0;
}

void usbpd_sink_set_request_fixed_voltage(Request_voltage_t requestVoltage)
bool usbpd_sink_set_request_fixed_voltage(Request_voltage_t requestVoltage)
{
uint16_t targetVoltage;
switch (requestVoltage)
Expand Down Expand Up @@ -73,11 +73,12 @@ void usbpd_sink_set_request_fixed_voltage(Request_voltage_t requestVoltage)
if(pdControl_g.cc_FixedSourceCap[i].Voltage == targetVoltage)
{
pdControl_g.cc_SetPDONum = i+1;
return;
return true;
}
}
pdControl_g.cc_SetPDONum = (pdControl_g.cc_SourcePDONum - pdControl_g.cc_SourcePPSNum);

// unsupported voltage
return false;
}

void timer3_init(uint16_t arr, uint16_t psc)
Expand Down
3 changes: 2 additions & 1 deletion libraries/USBPD_SINK/src/usbpd_sink.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
extern "C" {
#endif /* end of __cplusplus */

#include <stdbool.h>
#include "usbpd_def.h"

// Register Bit Definition
Expand Down Expand Up @@ -201,7 +202,7 @@ void usbpd_sink_process(void);
uint8_t usbpd_sink_get_ready(void);
void usbpd_sink_clear_ready(void);

void usbpd_sink_set_request_fixed_voltage(Request_voltage_t requestVoltage);
bool usbpd_sink_set_request_fixed_voltage(Request_voltage_t requestVoltage);


#ifdef __cplusplus
Expand Down