feat(metrics): Include air id in trace metrics #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
changed the title
| .collect::<Vec<_>>(); | ||
| let per_air: Vec<_> = zip_eq(&mpk.per_air, heights) | ||
| .map(|(pk, height)| { | ||
| let per_air: Vec<_> = zip_eq(mpk.air_ids.iter().copied(), zip_eq(&mpk.per_air, heights)) |
There was a problem hiding this comment.
just use izip! since we don't really need to check equal lengths
jonathanpwang
approved these changes
Oct 31, 2025
jonathanpwang
changed the title
jonathanpwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two airs have the same type (this is the case in powdr for
PowdrAirwhich can have many instances), their names are the same. In order to tell them apart in the metrics, use their id.