fully exhaust query map #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basfroman
approved these changes
Jun 27, 2025
Comment on lines
+188
to
+190
| @pytest.mark.asyncio | ||
| async def test_fully_exhaust_query_map(): | ||
| async with AsyncSubstrateInterface(LATENT_LITE_ENTRYPOINT) as substrate: |
There was a problem hiding this comment.
You want to move this tests to e2e tests or mock connection and stub the results bc it's real call and we use a real server every commit in staging with this test.
Comment on lines
+3517
to
+3521
| self.rpc_request( | ||
| method="state_queryStorageAt", | ||
| params=[batch_keys, block_hash], | ||
| runtime=runtime, | ||
| ) |
There was a problem hiding this comment.
What happens if one of the self.rpc_requests raises an error? For example, due to a short, temporary bad connection? Or a broken data structure?
You don't want to use return_exceptions=True for the gather and then filter the result? or use try except with logging in case of error?
basfroman
added
run-bittensor-sdk-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an arg to async substrate query map to fully exhaust the query map results rather than synchronously getting them by pagination.
In bigger tests such as
SubtensorModule.OwnedHotkeys, the speed improvement is 5-6X faster.