-
Notifications
You must be signed in to change notification settings - Fork 11
Add haproxy to benchmarking tool #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding as a proxy - a middle actor. Currently adding only for apache. Support all the encryption modes for haproxy: - client to proxy - proxy to server - client to server - pure http without encryption Currently adding it only for openssl-master crypto backend. Signed-off-by: Norbert Pocs <[email protected]>
bench-scripts/apache_bench.sh
Outdated
${RESULT_DIR}/httpd-ssl-${SSL_LIB}.conf | ||
|
||
if [[ "${HAPROXY}" = "server" ]] || [[ "${HAPROXY}" = "both" ]] ; then | ||
conf_siege_haproxy_cert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to call this twice within this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Norbert Pocs <[email protected]>
Signed-off-by: Norbert Pocs <[email protected]>
for OPTION in ${HAPROXY_OPTIONS} | ||
do | ||
run_test openssl-master ${OPTION} | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to have the same loop twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3x actually. This can be refactored, but I'd keep it in a separate PR.
The reason is that apache has 3 modes to operate: event, worker and prefork.
Adding as a proxy - a middle actor.
Currently adding only for apache.
Support all the encryption modes for haproxy:
Currently adding it only for openssl-master crypto backend.