Fix variable length SEQUENTIAL files #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes variable-length SEQUENTIAL file handling in the COBOL runtime and adds comprehensive test coverage. The primary purpose is to prevent buffer overruns when reading variable-length records by ensuring record sizes don't exceed configured maximums.
- Fixed a critical bug in
CobolSequentialFile.javawhere record sizes could exceed the maximum allowed size - Added a new test case to verify variable-length file reading functionality
- Integrated the new test into the build system and test suite
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolSequentialFile.java | Fixed record size assignment to prevent buffer overruns |
| tests/misc.src/variable-length-file.at | Added new test case for variable-length file handling |
| tests/misc.at | Included the new test in the test suite |
| tests/Makefile.am | Added test dependency for build system |
| tests/Makefile.in | Added test dependency for generated makefile |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tsh-hashimoto
approved these changes
Sep 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for testing variable-length file handling in the COBOL runtime and ensures that record sizes do not exceed the configured maximum. The changes include a bug fix for record size assignment, updates to the test suite to add coverage for variable-length files, and the addition of a new test case.
Bug fix and runtime improvement:
CobolSequentialFile.javadoes not exceed the configured maximum (record_max), preventing buffer overruns when reading variable-length records.Test suite enhancements:
misc.src/variable-length-file.atto the test dependencies in bothtests/Makefile.amandtests/Makefile.in, ensuring the new test is included in the build and test process. [1] [2]tests/misc.atto m4-includevariable-length-file.at.misc.src/variable-length-file.atthat verifies reading from a variable-length file, including COBOL source, file content checks, and expected output validation.