-
Notifications
You must be signed in to change notification settings - Fork 38
Add multiple file support to cobj-idx migrate and unlock commands with enhanced testing #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: yutaro-sakamoto <[email protected]>
cobj-idx unlock and cobj-idx migrate should handle multiple filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…RNAL Co-authored-by: yutaro-sakamoto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements multiple file support for the cobj-idx migrate and unlock commands, allowing users to process several indexed files in a single operation instead of running the commands individually for each file.
- Modified argument validation to accept multiple files and added iteration logic to process them sequentially
- Enhanced error handling to continue processing remaining files when individual files fail, with proper exit codes
- Updated test infrastructure to use dynamic file paths and added comprehensive verification tests for multiple file operations
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| IndexedFileUtilMain.java | Added multiple file support to migrate/unlock commands with improved error handling |
| migrate.at | Enhanced test to verify multiple file migration functionality with dynamic file paths |
| unlock.at | Added test case for unlocking multiple files simultaneously |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR implements support for multiple files in the
cobj-idx migrateandcobj-idx unlockcommands. Previously, these commands could only process one indexed file at a time, which was inefficient when working with multiple files.Changes Made
Command Line Interface:
migrateandunlockcommands now accept multiple file arguments[<indexed file>...]syntax indicating multiple files are supportedImplementation Details:
unrecognizedArgs.length != 2tounrecognizedArgs.length < 2Enhanced Testing:
check_file.cblto useASSIGN TO INDEX_FILE_PATHwith ASSIGN EXTERNAL feature for dynamic filename selectioncobj-idxscript classpath to enable proper test executionError Handling:
Example Usage
The implementation includes comprehensive testing that verifies each migrated file can be properly accessed for read and write operations, ensuring the migration process maintains data integrity across all processed files.
Fixes #707.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.