- 
                Notifications
    
You must be signed in to change notification settings  - Fork 38
 
Improve tests and CI #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            yutaro-sakamoto
  merged 11 commits into
  opensourcecobol:develop
from
yutaro-sakamoto:fix/tests
  
      
      
   
  Jan 13, 2023 
      
    
                
     Merged
            
            Improve tests and CI #66
                    yutaro-sakamoto
  merged 11 commits into
  opensourcecobol:develop
from
yutaro-sakamoto:fix/tests
  
      
      
   
  Jan 13, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
      
  
    Contributor
      
  
  
      
          
      
      
            yutaro-sakamoto
  
      
      
      commented
        Jan 11, 2023 
      
    
  
- 失敗しているテストをすべてスキップするようにした。
 - 1つでも失敗するテスト(スキップしたテストを除く)があればCIが失敗するようにした。
- 従来は、COBOL85以外のテストはたとえ失敗してもCIが成功するようになっていた。
 - この変更により以降の改修でCOBOL85以外のテストでもデグレードが検出できるようになる。
 
 - "run"テストをCIで実行するようにした。
 - "i18n_utf8"をCIで実行しないようにした。
- i18n_utf8は現状では起動できない。i18n_utf8の扱いは今後の課題とする。
 
 
| 
           COBOL85テストの実行にかかる時間を短縮した。  | 
    
              
                    kio-watanabe
  
              
              approved these changes
              
                  
                    Jan 13, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
承認しました。
    
  yutaro-sakamoto 
      added a commit
      that referenced
      this pull request
    
      Jan 13, 2023 
    
    
      
  
    
      
    
  
This reverts commit 9e29098.
| 
           問題があったので別のPull Requestで修正します。  | 
    
    
  yutaro-sakamoto 
      added a commit
      that referenced
      this pull request
    
      Jan 13, 2023 
    
    
  
    
  kio-watanabe 
      pushed a commit
        to kio-watanabe/opensourcecobol4j
      that referenced
      this pull request
    
      Apr 30, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.