FUNCTION SUBSTITUTE and FUNCTION SUBSTITUTE-CASE added #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutaro-sakamoto
requested changes
Nov 2, 2023
| } | ||
| } | ||
|
|
||
| byte[] p1 = fields[0].getDataStorage().getByteArray(); |
Contributor
There was a problem hiding this comment.
CobolDataStorageクラスのgetByteArray()メソッドは使用しないでください。このPRでついでに、このメソッドをCobolDataStorageから消してもらえますか。
集団項目や部分参照のことを考慮すると、このメソッドの使用は(よほど注意深くコーディングしない限り)不具合を引き起こします。
ただし、CobolDataStorageクラスのgetByteArray(int, int)は、(性能面を十分に検討した上で)使用して良いです。
Contributor
There was a problem hiding this comment.
@kio-watanabe
すみません、やはりgetByteArray()は使用しないように修正してください
| int varsize = p1.length; | ||
| int pi1 = 0; | ||
| int calcsize = 0; | ||
| int found = 0; |
Contributor
There was a problem hiding this comment.
このfoundの型はbooleanに変更することを推奨します。
Comment on lines
2234
to
2235
| AbstractCobolField field = CobolFieldFactory.makeCobolField(0, (CobolDataStorage) null, attr); | ||
| field.setSize(calcsize); |
Contributor
There was a problem hiding this comment.
単に
AbstractCobolField field = CobolFieldFactory.makeCobolField(calcsize, (CobolDataStorage) null, attr);と変更するのが良いでしょう
yutaro-sakamoto
approved these changes
Nov 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FUNCTION SUBSTITUTE and FUNCTION SUBSTITUTE-CASE are added.
Four failing tests now pass.