fix(libcob): NATIONAL項目のMOVEのメモリ違反の修正 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DISPLAY以外の数値項目からNATIONAL項目へMOVEする際, 不正なメモリへの書き込みが発生していたため,該当箇所を修正した.
|
テストも通して問題なかったため、マージします。 |
|
I suggest to revise it, ideally there should be no merge if no test case was added (otherwise neither the bug is reproducible nor the correct behavior is ensured to be correct in the future, too). @ytr-sakamoto Can you please add a test to test/run.src/misc.at which would fail with the previous version and is now fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISPLAY以外の数値項目からNATIONAL項目へMOVEする際,
不正なメモリへの書き込みが発生していたため,該当箇所を修正した.