Use vbisam-osscons-patch instead of opensource-cobol/vbisam
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable vbisam-osscons-patch instead of opensourcecobol/vbisam
There was a problem hiding this comment.
Pull Request Overview
This PR switches the CI workflow from downloading and caching the original opensource-cobol/vbisam to using the vbisam-osscons-patch v2.0patch1 release.
- Updated cache directory and path to
vbisam-osscons-patch-2.0patch1 - Changed download URL, extraction directory, and working-directory to the new patch version
Comments suppressed due to low confidence (3)
.github/workflows/ci.yml:39
- Update this comment to reflect the actual cached directory 'vbisam-osscons-patch-2.0patch1' for clarity.
# Cache the directory 'vbisam'
.github/workflows/ci.yml:45
- Include the patch version in the cache key (e.g.,
vbisam-2.0patch1-${{ matrix.os }}-key) to avoid reusing stale caches when the version changes.
key: vbisam-${{ matrix.os }}-key
.github/workflows/ci.yml:48
- [nitpick] Consider renaming this step to
Download and build vbisam-osscons-patchfor consistency with the new package name.
- name: Download vbisam and Build it
yutaro-sakamoto
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GnuCOBOL is built with the
--with-vbisamoption, using VBISAM from opensource COBOL.So I update CI to use
vbisam-osscons-patch.