Drop fallback code for missing extension module #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback code originally ran if OpenSlide Python was installed --without-performance, but setuptools 46 dropped the Feature mechanism and 298b5a9 removed --without-performance from setup.py. There is now no mechanism for providing default-enabled optional features in Python packages. The fallback case was originally added for Windows users who don't have MSVC installed, but we now distribute precompiled Python wheels for Windows, so it should be okay to just require the compiled module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback code originally ran if OpenSlide Python was installed
--without-performance, but setuptools 46 dropped theFeaturemechanism and #76 removed--without-performancefromsetup.py. There is now no mechanism for providing default-enabled optional features in Python packages.The fallback case was originally added for Windows users who don't have MSVC installed, but we now distribute precompiled Python wheels for Windows, so it should be okay to just require the compiled module.