Skip to content

NO-ISSUE: Update to new feature-gate options in helm #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

NO-ISSUE: Update to new feature-gate options in helm #537

merged 1 commit into from
Oct 23, 2025

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 22, 2025

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2025

@tmshort: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Oct 23, 2025

/test openshift-e2e-aws

camilamacedo86
camilamacedo86 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianzhangbjz
Copy link
Contributor

jianzhangbjz commented Oct 23, 2025

/verified by pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

@jianzhangbjz: This PR has been marked as verified by pass.

In response to this:

/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Oct 23, 2025

/test openshift-e2e-aws

@tmshort
Copy link
Contributor Author

tmshort commented Oct 23, 2025

/hold
Hold in favor of #532, since we need to get that one in, and any other PR that merges will update it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Oct 23, 2025

/unhold
#532 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3caf02d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

/retest-required

Remaining retests: 0 against base HEAD 6caf943 and 2 for PR HEAD 3caf02d in total

@openshift-merge-bot openshift-merge-bot bot merged commit d85d491 into openshift:main Oct 23, 2025
11 of 12 checks passed
@tmshort tmshort deleted the update-featute-gates-in-helm branch October 23, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

1 more reviewer

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort @openshift-ci-robot @camilamacedo86 @jianzhangbjz