WIP: Test commitchecker

[jsafrane]

This is a copy of #525 to test commitchecker

[jsafrane]

/test verify-commits

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/test verify-commits

[jsafrane]

Observation:

• with main as the base of my branch, commit checker fails: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_operator-framework-operator-controller/529/pull-ci-openshift-operator-framework-operator-controller-main-verify-commits/1979106910430826496

• with c911522 as the base of my PR (same base as OCPQE-30673: migrate some clustercatalog cases to ote #525), the commit checker succeeds: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_operator-framework-operator-controller/529/pull-ci-openshift-operator-framework-operator-controller-main-verify-commits/1979107753968275456

[jsafrane]

/test unit

[jsafrane]

/test verify-commits

[jsafrane]

Checking the env. variables set in the job, I think commitchecker needs to evaluate commits between current HEAD with the PR applied and $PULL_BASE_SHA - the merge base.

[jsafrane]

It seems to be related to openshift/build-machinery-go#82...

[jsafrane]

I think I know what's wrong. commitchecker checks commits between the last rebase to upstream and the PR. #525 merge base is before the last rebase.

[jsafrane]

I think commitchecker needs a better way how to detect rebase PRs and treat them special. In a regular PR, it should really check just $PULL_BASE_SHA..HEAD.

Commitchecker seems to detect rebases mostly OK, it's confused only when the PR base is before the last rebase.

[jsafrane]

/test unit

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	b1a6062	link	true	/test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.