Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 7, 2025

To promote a feature gate to GA, one of the required criteria is to have at least five tests covering that feature.

This PR adds two new tests for the Single/Own Namespace feature gate to increase its test coverage and help meet the GA promotion criteria.

Tests to avoid flakes - Requirement for new tests
periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 5
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6db4eb30-a444-11f0-8c9a-d568d3d45271-0

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
@openshift-ci openshift-ci bot requested review from pedjak and trgeiger October 7, 2025 11:17
@camilamacedo86 camilamacedo86 force-pushed the new-tests-webhook branch 3 times, most recently from 1959dab to 80bdf3d Compare October 7, 2025 11:35
@perdasilva
Copy link
Contributor

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/262b6a50-a386-11f0-8fc8-fe6c209e51af-0

@camilamacedo86 camilamacedo86 force-pushed the new-tests-webhook branch 5 times, most recently from a26f4ca to 424779b Compare October 8, 2025 09:31
@camilamacedo86 camilamacedo86 changed the title WIP Add Single/Own Namespace tests Add Single/Own Namespace tests Oct 8, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
@camilamacedo86 camilamacedo86 changed the title Add Single/Own Namespace tests OPRUN-4134: Add Single/Own Namespace tests Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@camilamacedo86: This pull request references OPRUN-4134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 force-pushed the new-tests-webhook branch 4 times, most recently from 6c3e020 to 7739aea Compare October 8, 2025 09:43
@camilamacedo86 camilamacedo86 changed the title OPRUN-4134: Add Single/Own Namespace tests OPRUN-4134: Add 2 new tests for Single/Own Namespace install mode support Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@camilamacedo86: This pull request references OPRUN-4134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

In order to promote a feature gate to GA, one of the required criteria is to have at least five tests covering that feature.

This PR adds two new tests for the Single/Own Namespace feature gate to increase its test coverage and help meet the GA promotion criteria.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@camilamacedo86: This pull request references OPRUN-4134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

To promote a feature gate to GA, one of the required criteria is to have at least five tests covering that feature.

This PR adds two new tests for the Single/Own Namespace feature gate to increase its test coverage and help meet the GA promotion criteria.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a525a770-a42c-11f0-9fc8-d8dfbf1c5e71-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@camilamacedo86: This pull request references OPRUN-4134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

To promote a feature gate to GA, one of the required criteria is to have at least five tests covering that feature.

This PR adds two new tests for the Single/Own Namespace feature gate to increase its test coverage and help meet the GA promotion criteria.

Tests to avoid flakes - Requirement for new tests

periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a525a770-a42c-11f0-9fc8-d8dfbf1c5e71-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title OPRUN-4134: Add 2 new tests for Single/Own Namespace install mode support WIP: OPRUN-4134: Add 2 new tests for Single/Own Namespace install mode support Oct 8, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3f2230e0-a5be-11f0-8b03-42a91f29dbe7-0

@bandrade
Copy link

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@camilamacedo86: This pull request references OPRUN-4134 which is a valid jira issue.

In response to this:

To promote a feature gate to GA, one of the required criteria is to have at least five tests covering that feature.

This PR adds two new tests for the Single/Own Namespace feature gate to increase its test coverage and help meet the GA promotion criteria.

Tests to avoid flakes - Requirement for new tests
periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 5
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6db4eb30-a444-11f0-8c9a-d568d3d45271-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 10, 2025
@openshift-ci-robot
Copy link

@bandrade: This PR has been marked as verified by @bandrade.

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Oct 10, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@tmshort: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/110405a0-a60c-11f0-85ff-c88f511bac86-0

@camilamacedo86
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56ba6480-a617-11f0-82e9-cc96701d919b-0

@tmshort
Copy link
Contributor

tmshort commented Oct 10, 2025

/lgtm
/hold
Holding until payload-aggregate runs.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@camilamacedo86
Copy link
Contributor Author

In all aggregation tests, we can confirm that the new 2 tests passed without failures:

Screenshot 2025-10-13 at 08 23 11 Screenshot 2025-10-13 at 08 23 30

Issues faced in the aggregation are not related to those new testes.

P.S.: Calling it to run 10 times did not work (it was executed only 5 times, maybe because we already had an execution in progress at the time).

c/c @tmshort

@camilamacedo86
Copy link
Contributor Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7cc20ef0-a809-11f0-8f58-bb64e611ce36-0

@camilamacedo86
Copy link
Contributor Author

/hold cancel

As we discussed in the seal pod, no failures have been faced so far
The aggregation seems to have an issue that does not execute 10 times in a row
more info: #502 (comment)

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@tmshort
Copy link
Contributor

tmshort commented Oct 13, 2025

/hold
Because we had to do a manual sync (#519), if this goes in before the manual sync happens, the manual sync will need to be regenerated...

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@camilamacedo86
Copy link
Contributor Author

(#519) is merged now
So, I am

/hold cancel

c/c @tmshort

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a15517d and 2 for PR HEAD 80ddfb6 in total

@camilamacedo86
Copy link
Contributor Author

/test openshift-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 80ddfb6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1f66d6f and 1 for PR HEAD 80ddfb6 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 110bda6 into openshift:main Oct 14, 2025
12 of 13 checks passed
@camilamacedo86 camilamacedo86 deleted the new-tests-webhook branch October 15, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants