OPRUN-4169: OTE building controller image #483
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
ote-dc-test
branch
from
2bd38fa to
c5b3c4b
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 5 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fc1e6420-9957-11f0-85bf-af374a10d3ea-0 |
perdasilva
force-pushed
the
ote-dc-test
branch
from
c5b3c4b to
e9ce10c
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 5 |
|
@perdasilva: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 5 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fda12af0-9a04-11f0-8abc-e1b342e60427-0 |
perdasilva
force-pushed
the
ote-dc-test
branch
2 times, most recently
from
ffd9ab7 to
42a85d1
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 1 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4f782950-9d43-11f0-9ce3-c7dc4b9b6993-0 |
perdasilva
force-pushed
the
ote-dc-test
branch
2 times, most recently
from
3110080 to
d177028
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 1 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d4e1e7b0-9d4e-11f0-9c06-673c7c8b1fa8-0 |
perdasilva
force-pushed
the
ote-dc-test
branch
from
d177028 to
0b3e6b0
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 1 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e6789ad0-9d55-11f0-9f30-747af7593e18-0 |
|
/test ci/prow/openshift-e2e-aws-techpreview |
|
@perdasilva: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 5 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8063deb0-9e01-11f0-9265-98260a5fdaeb-0 |
perdasilva
force-pushed
the
ote-dc-test
branch
from
3063256 to
4747d6c
Compare
perdasilva
changed the title
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@perdasilva: This pull request references OPRUN-4169 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@perdasilva: This pull request references OPRUN-4169 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6-techpreview 10 |
|
@perdasilva: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8573b970-9f96-11f0-83a7-78fb89bc68af-0 |
openshift/tests-extension/Makefile
Outdated
| @# Check if KUBECONFIG is set and not empty | ||
| @if [ -z "$(KUBECONFIG)" ]; then \ | ||
| echo "Please set KUBECONFIG first"; \ | ||
| exit 1; \ | ||
| fi |
There was a problem hiding this comment.
KUBECONFIG is not the only method to reach a cluster, there's also oc config get-context and other config commands.
There was a problem hiding this comment.
KUBECONFIG being set seems to be a requirement for updating metadata. It seems to be failing without error code - that's why I put this check here to make sure we fail loudly. I'll update the message to make that clearer. Thanks for calling this out!
There was a problem hiding this comment.
So, for more info, here's the output without this guard:
make update-metadata perdasilva@nibbler
/home/perdasilva/repos/perdasilva/operator-framework-operator-controller/openshift/tests-extension/bin/olmv1-tests-ext update --component openshift:payload:olmv1
Please set KUBECONFIG first!
make clean-metadata
make[1]: Entering directory '/home/perdasilva/repos/perdasilva/operator-framework-operator-controller/openshift/tests-extension'
Cleaning metadata (removing codeLocations)...
make[1]: Leaving directory '/home/perdasilva/repos/perdasilva/operator-framework-operator-controller/openshift/tests-extension'
There was a problem hiding this comment.
I did a bit more digging and found out the source of the issue. I've reverted this change and reached out to Kui to see what we could do about fixing it.
| gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| k8s.io/cloud-provider v0.0.0 // indirect |
There was a problem hiding this comment.
Why were a bunch of these v0.0.0?? Weird
There was a problem hiding this comment.
strange indeed - could it be related to dependencies pointing to shas instead of releases?
|
Just a few nits, but fine otherwise. |
…er image Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
ote-dc-test
branch
from
4747d6c to
880a090
Compare
|
@perdasilva: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
techpreview failure was |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@perdasilva: This pull request references OPRUN-4169 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
|
@bandrade: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit d6b8f7f
into
openshift:main
5 participants
No description provided.