-
Notifications
You must be signed in to change notification settings - Fork 35
OCPQE-29416:Init OLMv1 OTE Framework for tests-private to migrate first case #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
35711d9 to
2fc37c7
Compare
|
@kuiwang02: This pull request references OCPQE-29416 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ec6182c0-8e1b-11f0-97d0-7d76e5f47d8d-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07902100-8e1c-11f0-9d27-1b2214be72fa-0 |
|
/label tide/merge-method-rebase |
|
I'm a bit concerned about the size of this PR and its effect on the bumper. 5,000+ files changed. |
0eabc18 to
f73d456
Compare
@tmshort The QE testing framework depends on k8s.io/kubernetes/test/e2e/framework. That dependency pulls a large number of files into vendor. To make the cases migrate smoothly with minimal changes, we kept that dependency during migration. Before opening the PR I trimmed some libraries from the original QE framework to reduce the number of files, but there were still many. I’ve now further slimmed it down — removing 1,920 files overall — and I can’t reduce it any more without causing build failures (I tried; further removals break compilation). Thanks for your understanding. If you think the PR is acceptable, please add an lgtm so the QE team can begin migrating the cases. Thanks! if not, could I spilt the PR to two PRs to introduce the vendor files so that there are not so many files in one PR? thanks |
f73d456 to
bd58c80
Compare
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-techpreview 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1236f1c0-8ede-11f0-96b1-dd1a5c952822-0 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn 5 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f79b840-8ede-11f0-892b-8bb6861d4ead-0 |
|
Right now, we're having problems with the bumper PR, and I really need to figure that out. |
@tmshort thanks for the information. wait for your further notice, thanks. |
|
/hold |
|
/remove-label tide/merge-method-rebase |
|
/unhold |
|
/approve |
|
/label tide/merge-method-rebase |
|
@tmshort @perdasilva (in case you are online afternoon BJ time), could you please help approve it so that we can start next migration? thanks |
|
We don't need rebase anymore. |
openshift/tests-extension/Makefile
Outdated
| bindata: test/extended/testdata/bindata.go | ||
| test/extended/testdata/bindata.go: $(shell find test/extended/testdata -type f ! -name 'bindata.go') | ||
| mkdir -p $(@D) | ||
| $(GO_BINDATA) -nocompress -nometadata \ | ||
| -pkg testdata -o $@ -prefix "testextended" \ | ||
| -ignore "test/extended/testdata/bindata.go" test/extended/testdata/... | ||
| gofmt -s -w $@ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other bindata is located in pkg/bindata/, not sure if this was intentional, or...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmshort Thanks
I just followed the way of the tests-private, and now I change to pkg/bindata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this path:
openshift/tests-extension/test/extended
I really think that extended should be changed to something more descriptive? Like "qe" or "qe-private" or... I don't know - just throwing out ideas.
It feels as though this is not as integrated as the other tests, but perhaps that doesn't matter.
But the name "extended" just doesn't work for me because of the existing path. Can we come up with something better or more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmshort Thanks. Now I change to qe.
|
Regarding size: most of this is vendor, and well, I suppose there's no way to get around that, so I think we're fine. |
|
/test openshift-e2e-aws-techpreview |
2ceddb8 to
41bcf5b
Compare
@tmshort thanks |
|
@kuiwang02: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianzhangbjz, kuiwang02, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @jianzhangbjz |
|
@jianzhangbjz: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Init OLMv1 OTE Test Framework for tests-private Cases and Add Test Cases
Summary
This PR continue to init OTE framework for tests-private cases and implements initial test cases for ClusterCatalog and ClusterExtension functionality.
Changes
🏗️ Infrastructure & Dependencies
go.modandgo.sumwith required third-party packagestest/extended/directory🧪 Test Framework Components
Test utilities (
test/extended/util/):OLMv1-specific utilities (
test/extended/util/olmv1util/):Test data templates (
test/extended/testdata/olm/):🔍 Test Cases Implemented
1. ClusterCatalog Tests (
olmv1_cc.go)2. ClusterExtension Tests (
olmv1_ce.go)openshift-catalogdnamespace policiesopenshift-cluster-olm-operatornamespace policiesopenshift-operator-controllernamespace policies📁 Key Files Added/Modified
test/extended/specs/olmv1_cc.go- ClusterCatalog test implementationtest/extended/specs/olmv1_ce.go- ClusterExtension test implementationtest/extended/util/- Core test utilitiestest/extended/util/olmv1util/- OLMv1-specific utilitiestest/extended/testdata/olm/- Test data templatestest/extended/README.md- Documentation for the test frameworkcmd/main.go- Updated main entry pointTest Result
Usage
please refer to openshift/tests-extension/test/extended/README.md.
Assisted-by: Claude Code