-
Notifications
You must be signed in to change notification settings - Fork 218
USHIFT-6168: Adding scenario to enable all configs #5579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f349f05 to
c159bc4
Compare
|
@kasturinarra: This pull request references USHIFT-6168 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| EOF" | ||
|
|
||
| # Restart MicroShift to apply TLS configuration | ||
| run_command_on_vm host1 "sudo systemctl restart microshift" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use healthcheck to verify that MicroShift is fully initialized after restart.
Otherwise, we're risking to run into race conditions in the subsequent scripts.
| EOF" | ||
|
|
||
| # Restart MicroShift to apply TLS configuration | ||
| run_command_on_vm host1 "sudo systemctl restart microshift" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use healthcheck to verify that MicroShift is fully initialized after restart.
Otherwise, we're risking to run into race conditions in the subsequent scripts.
c159bc4 to
197f89d
Compare
0ae05f9 to
16cac1b
Compare
|
/retest |
24aabf9 to
dd1724b
Compare
|
/test e2e-aws-tests-release |
dd1724b to
f4d77fc
Compare
|
@kasturinarra: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses: This PR helps to add a scenario that enables all configs.
Closes #USHIFT-6168