Skip to content

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Nov 12, 2025

- What I did
This splits the singular existing MachineConfigNodeUpdateFilesAndOS MCN condition into MachineConfigNodeUpdateOS and MachineConfigNodeUpdateFiles for clusters where the ImageModeStatusReporting feature gate is enabled.

- How to verify it

  1. Launch a 4.21 tech preview cluster with this PR included.
  2. Apply a MachineConfig to trigger an update.
  3. Track the MCN conditions to make sure the MachineConfigNodeUpdateOS or MachineConfigNodeUpdateFiles conditions update, according to the type of update triggered.

- Description for the changelog
MCO-1870: Split MachineConfigNodeUpdateFilesAndOS condition into MachineConfigNodeUpdateOS and MachineConfigNodeUpdateFiles

…neConfigNodeUpdateOS' and 'MachineConfigNodeUpdateFiles' when 'ImageModeStatusReporting' is enabled
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2025

@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

- What I did
This splits the singular existing MachineConfigNodeUpdateFilesAndOS MCN condition into MachineConfigNodeUpdateOS and MachineConfigNodeUpdateFiles for clusters where the ImageModeStatusReporting feature gate is enabled.

- How to verify it

  1. Launch a 4.21 tech preview cluster with this PR included.
  2. Apply a MachineConfig to trigger an update.
  3. Track the MCN conditions to make sure the MachineConfigNodeUpdateOS or MachineConfigNodeUpdateFiles conditions update, according to the type of update triggered.

- Description for the changelog
MCO-1870: Split MachineConfigNodeUpdateFilesAndOS condition into MachineConfigNodeUpdateOS and MachineConfigNodeUpdateFiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen marked this pull request as draft November 12, 2025 21:18
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants