Skip to content

Conversation

@shirmoran
Copy link
Contributor

@shirmoran shirmoran commented Oct 29, 2025

- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

@shirmoran: This pull request references Jira Issue OCPBUGS-50492, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is To Do instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
This PR adds a service to port 9637

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

/retest-required

@isabella-janssen
Copy link
Member

/payload-job ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@isabella-janssen: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@isabella-janssen
Copy link
Member

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3d7e9d0-b4d7-11f0-9dd3-fe6a8d08a4fa-0

@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from b545186 to fe63fd5 Compare November 4, 2025 14:31
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2025
@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from fe63fd5 to ddb9d8a Compare November 4, 2025 14:33
This PR adds a service to port 9637. As for now since it does not have a
service, an endpointslice is not created and it is not included in the
communication matrix. Adding a service should solve this issue.
@shirmoran shirmoran force-pushed the add-kube-rbac-proxy-service branch from ddb9d8a to 3ccd953 Compare November 4, 2025 14:38
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2025
@shirmoran shirmoran requested a review from yuqi-zhang November 4, 2025 14:38
@yuqi-zhang
Copy link
Contributor

/test verify

Also cc @rphillips since you initially had some concerns around doing this for purely documentation generation purposes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@shirmoran: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 3ccd953 link false /test bootstrap-unit
ci/prow/okd-scos-e2e-aws-ovn 3ccd953 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

lgtm... It seems like that ship has sailed.

@yuqi-zhang yuqi-zhang changed the title OCPBUGS-50492: Add kube_rbac_proxy service OCPBUGS-65544: Add kube_rbac_proxy service Nov 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 12, 2025
@openshift-ci-robot
Copy link
Contributor

@shirmoran: This pull request references Jira Issue OCPBUGS-65544, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Would you be able to pre-merge verify that this satisfies the requirements @shirmoran ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shirmoran, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@sergiordlr
Copy link
Contributor

Verified using IPI on AWS

We can see the services for the needed ports

$ oc -n openshift-machine-config-operator get service  |grep 9637
kube-rbac-proxy             ClusterIP   172.30.175.71    <none>        9637/TCP              86m
$ oc -n openshift-machine-config-operator get service  |grep 22624
machine-config-server       ClusterIP   172.30.11.207    <none>        22623/TCP,22624/TCP   86m
$ oc -n openshift-machine-config-operator get service  |grep 22623
machine-config-server       ClusterIP   172.30.11.207    <none>        22623/TCP,22624/TCP   86m

Test case "[sig-mco] MCO ocb Author:ptalgulk-ConnectedOnly-Longduration-NonPreRelease-Medium-77977-Install extension after OCB is enabled [Disruptive] [Serial]" passed, and we were able to scale up and down the nodes without problems.

/label qe-approved
/verified by @sergiordlr

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 19, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 19, 2025
@openshift-ci-robot
Copy link
Contributor

@sergiordlr: This PR has been marked as verified by @sergiordlr.

In response to this:

Verified using IPI on AWS

We can see the services for the needed ports

$ oc -n openshift-machine-config-operator get service  |grep 9637
kube-rbac-proxy             ClusterIP   172.30.175.71    <none>        9637/TCP              86m
$ oc -n openshift-machine-config-operator get service  |grep 22624
machine-config-server       ClusterIP   172.30.11.207    <none>        22623/TCP,22624/TCP   86m
$ oc -n openshift-machine-config-operator get service  |grep 22623
machine-config-server       ClusterIP   172.30.11.207    <none>        22623/TCP,22624/TCP   86m

Test case "[sig-mco] MCO ocb Author:ptalgulk-ConnectedOnly-Longduration-NonPreRelease-Medium-77977-Install extension after OCB is enabled [Disruptive] [Serial]" passed, and we were able to scale up and down the nodes without problems.

/label qe-approved
/verified by @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@shirmoran: This pull request references Jira Issue OCPBUGS-65544, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 759466d into openshift:main Nov 19, 2025
13 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@shirmoran: Jira Issue Verification Checks: Jira Issue OCPBUGS-65544
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65544 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

- What I did
This PR adds a service to port 9637. As for now since it does not have a service, an endpointslice is not created and it is not included in the communication matrix. Adding a service should solve this issue.

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants