MCO-1741: Add cloud providers to the kubernetes vendor #5145
Conversation
In CI we have observed that we really need the kubernetes testing framework cloud providers. As nothing is pointing to them they are not vendored in, so by adding a blank import now all are imported.
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-1741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/test unit |
|
/retest |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
logically lgtm, happy to let this merge and try to validate via the origin PR
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this can't affect gcp so /override ci/prow/e2e-gcp-op Until GCP gets fixed |
|
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-ovn |
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit febcfba
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
4 participants
In CI we have observed that we really need the kubernetes testing framework cloud providers.
As nothing is pointing to them they are not vendored in, so by adding a blank import now all are imported.
- What I did
Vendor in the kubernetes framework Cloud providers.
- How to verify it
Run our OTE binary using the TEST_PROVIDER environment variable pointing to a non-default cloud provider, like this:
- Description for the changelog
A blank import was added to vendor the necessary but unreferenced Kubernetes testing framework cloud providers for CI.