MCO-1719: MVP port of the MCO extended QE test suite #5108

pablintino · 2025-06-05T11:20:15Z

- What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

- How to verify it

Spin up a cluster
Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive
Ensure the tests in the MCO-1651 spike are listed and pass.

- Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

openshift-ci-robot · 2025-06-05T11:20:19Z

@pablintino: This pull request references MCO-1719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-06-05T11:20:19Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-06-10T09:12:47Z

@pablintino: This pull request references MCO-1719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

- How to verify it

Spin up a cluster

Run the new added command e2e-extended run-suite mco/full

Ensure the tests in the MCO-1651 spike are listed and pass.

- Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-06-10T09:12:50Z

@pablintino: This pull request references MCO-1719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

- How to verify it

Spin up a cluster

Run the new added command e2e-extended run-suite mco/full

Ensure the tests in the MCO-1651 spike are listed and pass.

- Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

test/extended/mco_layering.go

test/extended/const.go

yuqi-zhang · 2025-06-23T17:50:23Z

/lgtm

Re-applying

openshift-ci · 2025-06-23T17:53:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pablintino,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pablintino · 2025-06-23T19:03:52Z

/unhold
Agreement between QE and Dev on the pending naming convention. Merging.

pablintino · 2025-06-23T19:21:16Z

/retest-required

openshift-ci-robot · 2025-06-23T20:40:49Z

/retest-required

Remaining retests: 0 against base HEAD 0fd8575 and 2 for PR HEAD 57cf438 in total

openshift-ci-robot · 2025-06-24T01:40:36Z

/retest-required

Remaining retests: 0 against base HEAD 2499d89 and 1 for PR HEAD 57cf438 in total

pablintino · 2025-06-24T10:47:54Z

/test e2e-gcp-op

sergiordlr · 2025-06-24T11:40:05Z

Verified using IPI on AWS

Make the binary to execute the tests

$ make machine-config-tests-ext

Execute the OCL test cases

$ ./_output/linux/amd64/machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive | tee /tmp/out

Check that all test cases passed

$ cat /tmp/out |grep -E 'result|name"'
    "name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][OCPFeatureGate:OnClusterBuild][Serial][Disruptive] MCO ocb PolarionID:73494-A valid MachineOSConfig leads to a successful MachineOSBuild and cleanup of its associated resources",
    "result": "passed",
    "name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][OCPFeatureGate:OnClusterBuild][Serial][Disruptive] MCO ocb PolarionID:73599-A MachineOSConfig fails to apply or degrades if invalid inputs are given",
    "result": "passed",
    "name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][OCPFeatureGate:OnClusterBuild][Serial][Disruptive] MCO ocb PolarionID:77782-A MachineOSConfig with an unfinished build can be re-build",
    "result": "passed",
    "name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][OCPFeatureGate:OnClusterBuild][Serial][Disruptive] MCO ocb PolarionID:73496-A MachineOSConfig with custom containerfile definition can be successfully applied",
    "result": "passed",
    "name": "[sig-mco][Suite:openshift/machine-config-operator/disruptive][OCPFeatureGate:OnClusterBuild][Serial][Disruptive] MCO ocb PolarionID:77781-A successfully built MachineOSConfig can be re-build",
    "result": "passed",

/label qe-approved

openshift-ci-robot · 2025-06-24T11:40:12Z

@pablintino: This pull request references MCO-1719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

This changes moves/copies the extended QE test suites to our repo to be consumed by upstream CI for OCL component readiness.
The ported code is the bare minimum required to run the selected tests (choosen by this spike). The code has been also updated to match the Golang capabilities our version has, to align it with our linting rules and to try to minimize the amount of external dependencies.

- How to verify it

Spin up a cluster

Run the new added command machine-config-tests-ext run-suite openshift/machine-config-operator/disruptive

Ensure the tests in the MCO-1651 spike are listed and pass.

- Description for the changelog

This change integrates a minimal, updated subset of the extended MCO QE test suites into the repository to enable upstream CI validation for the OCL component.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang · 2025-06-24T13:01:19Z

/override e2e-gcp-op

openshift-ci · 2025-06-24T13:02:05Z

@yuqi-zhang: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-gcp-op

Only the following failed contexts/checkruns were expected:

ci/prow/bootstrap-unit
ci/prow/e2e-agent-compact-ipv4
ci/prow/e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-windows
ci/prow/e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op
ci/prow/e2e-gcp-op-ocl
ci/prow/e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-techpreview
ci/prow/e2e-hypershift
ci/prow/e2e-openstack
ci/prow/images
ci/prow/okd-scos-e2e-aws-ovn
ci/prow/security
ci/prow/unit
ci/prow/verify
ci/prow/verify-deps
pull-ci-openshift-machine-config-operator-main-bootstrap-unit
pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-windows
pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-techpreview
pull-ci-openshift-machine-config-operator-main-e2e-hypershift
pull-ci-openshift-machine-config-operator-main-e2e-openstack
pull-ci-openshift-machine-config-operator-main-images
pull-ci-openshift-machine-config-operator-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-security
pull-ci-openshift-machine-config-operator-main-unit
pull-ci-openshift-machine-config-operator-main-verify
pull-ci-openshift-machine-config-operator-main-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yuqi-zhang · 2025-06-24T13:02:08Z

Sorry, wrong command
/override ci/prow/e2e-gcp-op

openshift-ci · 2025-06-24T13:03:41Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op

In response to this:

Sorry, wrong command
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-06-24T18:15:53Z

/retest-required

Remaining retests: 0 against base HEAD 2499d89 and 2 for PR HEAD 57cf438 in total

openshift-ci-robot · 2025-06-24T23:45:51Z

/retest-required

Remaining retests: 0 against base HEAD 2499d89 and 2 for PR HEAD 57cf438 in total

openshift-ci · 2025-06-25T04:23:24Z

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`57cf438`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-gcp-op-ocl	`57cf438`	link	false	`/test e2e-gcp-op-ocl`
ci/prow/e2e-azure-ovn-upgrade-out-of-change	`57cf438`	link	false	`/test e2e-azure-ovn-upgrade-out-of-change`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-06-25T10:41:46Z

/retest-required

Remaining retests: 0 against base HEAD 2499d89 and 2 for PR HEAD 57cf438 in total

yuqi-zhang · 2025-06-25T13:08:04Z

/override ci/prow/e2e-gcp-op

openshift-ci · 2025-06-25T13:08:26Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op

In response to this:

/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-06-25T16:19:40Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202506251513.p0.g36a1298.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025

pablintino force-pushed the mco-qe-testsuite-port branch 5 times, most recently from a4ef58b to 53fabde Compare June 10, 2025 08:58

pablintino changed the title ~~MCO-1719: PoC to port the internal MCO test suite~~ MCO-1719: MVP port of the MCO extended QE test suite Jun 10, 2025

pablintino marked this pull request as ready for review June 10, 2025 09:13

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2025

openshift-ci bot requested review from RishabhSaini and cheesesashimi June 10, 2025 09:14

ptalgulk01 reviewed Jun 10, 2025

View reviewed changes

test/extended/mco_layering.go Outdated Show resolved Hide resolved

pablintino force-pushed the mco-qe-testsuite-port branch 2 times, most recently from ab044e3 to 9e7d857 Compare June 10, 2025 12:02

isabella-janssen reviewed Jun 10, 2025

View reviewed changes

test/extended/const.go Outdated Show resolved Hide resolved

pablintino force-pushed the mco-qe-testsuite-port branch 9 times, most recently from 35f5aa0 to f8bf543 Compare June 13, 2025 09:57

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025

pablintino added 3 commits June 23, 2025 16:22

Cleanup for MVP

26679cc

Fill test provider with origin info

a0d42d8

Fix dependencies

57cf438

pablintino force-pushed the mco-qe-testsuite-port branch from e5f0c93 to 57cf438 Compare June 23, 2025 14:22

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 24, 2025

isabella-janssen mentioned this pull request Jun 25, 2025

NO-ISSUE: API & client-go version bumps #5142

Merged

openshift-merge-bot bot merged commit 36a1298 into openshift:main Jun 25, 2025
17 of 20 checks passed

MCO-1719: MVP port of the MCO extended QE test suite #5108

MCO-1719: MVP port of the MCO extended QE test suite #5108

Uh oh!

Conversation

pablintino commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 5, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jun 5, 2025

Uh oh!

openshift-ci-robot commented Jun 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuqi-zhang commented Jun 23, 2025

Uh oh!

openshift-ci bot commented Jun 23, 2025

Uh oh!

pablintino commented Jun 23, 2025

Uh oh!

pablintino commented Jun 23, 2025

Uh oh!

openshift-ci-robot commented Jun 23, 2025

Uh oh!

openshift-ci-robot commented Jun 24, 2025

Uh oh!

pablintino commented Jun 24, 2025

Uh oh!

sergiordlr commented Jun 24, 2025

Uh oh!

openshift-ci-robot commented Jun 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

yuqi-zhang commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 24, 2025

Uh oh!

openshift-ci-robot commented Jun 24, 2025

Uh oh!

openshift-ci-robot commented Jun 24, 2025

Uh oh!

openshift-ci bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 25, 2025

Uh oh!

yuqi-zhang commented Jun 25, 2025

Uh oh!

openshift-ci bot commented Jun 25, 2025

Uh oh!

Uh oh!

openshift-bot commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pablintino commented Jun 5, 2025 •

edited

Loading

openshift-ci-robot commented Jun 5, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 10, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 10, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 24, 2025 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Jun 25, 2025 •

edited

Loading