Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #5088

/assign openshift-cherrypick-robot

/cherrypick release-4.17

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56829 has been cloned as Jira Issue OCPBUGS-56867. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-56867: Only update boot disks during GCP boot image updates

In response to this:

This is an automated cherry-pick of #5088

/assign openshift-cherrypick-robot

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-56829: Only update boot disks during GCP boot image updates [release-4.18] OCPBUGS-56867: Only update boot disks during GCP boot image updates May 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 29, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56867, which is invalid:

  • expected dependent Jira Issue OCPBUGS-56829 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #5088

/assign openshift-cherrypick-robot

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented May 29, 2025

/assign djoshy
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 29, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change d40190a link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl d40190a link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ptalgulk01
Copy link

ptalgulk01 commented May 30, 2025

Pre-merge verified here:
Verified using IPI based GCP 4.18 cluster

  • Edit the machinesets value by adding extra disk where the boot is true
$oc edit machinesets.machine.openshift.io  -n openshift-machine-api ppt-3005b-bmphl-worker-f 
          - autoDelete: true
            boot: true
            image: projects/rhcos-cloud/global/images/rhcos-418-94-202501221327-0-gcp-x86-64
            labels: {}
            sizeGb: 200
            type: pd-ssd
  • Scale that machinesets
oc scale --replicas 1 machinesets.machine.openshift.io -n openshift-machine-api ppt-3005b-bmphl-worker-f
machineset.machine.openshift.io/ppt-3005b-bmphl-worker-f scaled
  • See the machine is provisioned and running
oc get machines
NAME                             PHASE          TYPE            REGION        ZONE            AGE
oc get machines
NAME                             PHASE     TYPE            REGION        ZONE            AGE
ppt-3005b-bmphl-master-0         Running   n2-standard-4   us-central1   us-central1-a   54m
ppt-3005b-bmphl-master-1         Running   n2-standard-4   us-central1   us-central1-b   54m
ppt-3005b-bmphl-master-2         Running   n2-standard-4   us-central1   us-central1-c   54m
ppt-3005b-bmphl-worker-a-hx992   Running   n2-standard-4   us-central1   us-central1-a   47m
ppt-3005b-bmphl-worker-b-chdl9   Running   n2-standard-4   us-central1   us-central1-b   47m
ppt-3005b-bmphl-worker-c-75xxf   Running   n2-standard-4   us-central1   us-central1-c   47m
ppt-3005b-bmphl-worker-f-mjmlc   Running   n2-standard-4   us-central1   us-central1-f   8m13s

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 30, 2025
@djoshy
Copy link
Contributor

djoshy commented May 30, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-56867, which is invalid:

  • expected dependent Jira Issue OCPBUGS-56829 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Contributor

djoshy commented Jun 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 2, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-56867, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56829 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-56829 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr June 2, 2025 12:45
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 231e9db and 2 for PR HEAD d40190a in total

@openshift-merge-bot openshift-merge-bot bot merged commit 89d3f29 into openshift:release-4.18 Jun 2, 2025
17 of 19 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56867: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56867 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #5088

/assign openshift-cherrypick-robot

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #5102

In response to this:

This is an automated cherry-pick of #5088

/assign openshift-cherrypick-robot

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202506022302.p0.g89d3f29.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.