Skip to content

[release-4.20] OCPBUGS-65708: Set updateDomainCount to one when faultDomainCount is one #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

[release-4.20] OCPBUGS-65708: Set updateDomainCount to one when faultDomainCount is one #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/cloud/azure/services/availabilitysets/availabilitysets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ type Spec struct {
Name string
}

const defaultPlatformUpdateDomainCount = 5

// CreateOrUpdate creates or updates the availability set with the given name.
func (s *Service) CreateOrUpdate(ctx context.Context, spec azure.Spec) error {
availabilitysetsSpec, ok := spec.(*Spec)
Expand All @@ -37,6 +39,11 @@ func (s *Service) CreateOrUpdate(ctx context.Context, spec azure.Spec) error {
return fmt.Errorf("failed to get fault domain count: %w", err)
}

updateDomainCount := defaultPlatformUpdateDomainCount
if faultDomainCount == 1 {
updateDomainCount = 1
}

availabilitySet = compute.AvailabilitySet{
Name: to.StringPtr(availabilitysetsSpec.Name),
Sku: &compute.Sku{
Expand All @@ -45,7 +52,7 @@ func (s *Service) CreateOrUpdate(ctx context.Context, spec azure.Spec) error {
Location: to.StringPtr(s.Scope.Location()),
AvailabilitySetProperties: &compute.AvailabilitySetProperties{
PlatformFaultDomainCount: to.Int32Ptr(int32(faultDomainCount)),
PlatformUpdateDomainCount: to.Int32Ptr(int32(5)),
PlatformUpdateDomainCount: to.Int32Ptr(int32(updateDomainCount)),
},
Tags: s.Scope.Tags,
}
Expand Down