Skip to content

OCPCLOUD-3088: Bump k8s 1.34 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2025
Merged

OCPCLOUD-3088: Bump k8s 1.34 #169

merged 2 commits into from
Nov 12, 2025

Conversation

@sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Oct 31, 2025

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025 •
edited by openshift-ci bot
Loading

@sunzhaohua2: This pull request references OCPCLOUD-3088 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2025
@openshift-ci openshift-ci bot requested review from RadekManak and damdo October 31, 2025 02:05
@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Oct 31, 2025

/hold
seems need to wait machine-api-operator rebase

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025
@damdo
Copy link
Member

damdo commented Nov 10, 2025

@sunzhaohua2 this can now be updated to include the latest main changes from https://github.com/openshift/machine-api-operator

damdo
damdo reviewed Nov 10, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunzhaohua2 looks great, only a small nit

Makefile Outdated
BUILD_IMAGE ?= registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.21

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.32.1
Copy link
Member

@damdo damdo Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENVTEST_K8S_VERSION = 1.32.1
ENVTEST_K8S_VERSION = 1.34.1

@damdo
Copy link
Member

damdo commented Nov 10, 2025

/test regression-clusterinfra-azure-ipi-mapi-3of3

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@sunzhaohua2: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

damdo
damdo reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Nov 12, 2025

/verified by @sunzhaohua2
regression job passed.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 12, 2025

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

In response to this:

/verified by @sunzhaohua2
regression job passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sunzhaohua2
Copy link
Contributor Author

sunzhaohua2 commented Nov 12, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ceda5b5 into openshift:main Nov 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@RadekManak RadekManak Awaiting requested review from RadekManak

Assignees

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunzhaohua2 @openshift-ci-robot @damdo