Skip to content

CORS-4277: Ensure Throughput setting is honoured on gp3 volumes #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CORS-4277: Ensure Throughput setting is honoured on gp3 volumes #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/actuators/machine/instances.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ func getBlockDeviceMappings(machine runtimeclient.ObjectKey, blockDeviceMappingS
}

// IOPS settings are only valid on IO1, IO2 and GP3 block devices
// Throughput settings are only valid on GP3 block devices
// https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ec2/create-volume.html
switch aws.StringValue(volumeType) {
case ec2.VolumeTypeIo1, ec2.VolumeTypeIo2, ec2.VolumeTypeGp3:
Expand All @@ -325,6 +326,9 @@ func getBlockDeviceMappings(machine runtimeclient.ObjectKey, blockDeviceMappingS
if blockDeviceMappingSpec.EBS.Iops != nil && *blockDeviceMappingSpec.EBS.Iops > 0 {
blockDeviceMapping.Ebs.Iops = blockDeviceMappingSpec.EBS.Iops
}
if volumeType == ec2.VolumeTypeGp3 && blockDeviceMappingSpec.EBS.ThroughputMib != nil && *blockDeviceMappingSpec.EBS.ThroughputMib > 0 {
blockDeviceMapping.Ebs.Throughput = blockDeviceMappingSpec.EBS.ThroughputMib
}
}

if aws.StringValue(blockDeviceMappingSpec.EBS.KMSKey.ID) != "" {
Expand Down