Skip to content

Conversation

@bharath-b-rh
Copy link
Contributor

PR contains below commits

  • Removes feature gates checks for configuring GCP labels and tags, as the feature is GA.
  • Changes suggested by fmt tool.

Required for openshift/api#2372

@bharath-b-rh bharath-b-rh changed the title Oape 232 OAPE-232: Remove GCPLabelsTags featuregate checks and references Jun 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 30, 2025

@bharath-b-rh: This pull request references OAPE-232 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

PR contains below commits

  • Removes feature gates checks for configuring GCP labels and tags, as the feature is GA.
  • Changes suggested by fmt tool.

Required for openshift/api#2372

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2025

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-multi-vcenter 48cf15d link false /test e2e-vsphere-ovn-multi-vcenter
ci/prow/e2e-vsphere-static-ovn 48cf15d link false /test e2e-vsphere-static-ovn
ci/prow/e2e-nutanix 48cf15d link false /test e2e-nutanix
ci/prow/e2e-vsphere-host-groups-ovn 48cf15d link false /test e2e-vsphere-host-groups-ovn
ci/prow/e2e-vsphere-ovn-techpreview-serial 48cf15d link false /test e2e-vsphere-ovn-techpreview-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bharath-b-rh
Copy link
Contributor Author

/retest-required

@theobarberbany
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 86404b8 into openshift:main Jul 4, 2025
29 of 34 checks passed
@bharath-b-rh bharath-b-rh deleted the oape-232 branch July 4, 2025 18:05
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.20.0-202507041843.p0.g86404b8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants