Backport pull request #3522 from clwluvw/hidden-device in cadvisor v0.51.0 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysfs: trim spaces in device hidden check (cherry picked from commit 96c346e) Backports google#3522 from cadvisor v0.51.0. This is needed to fix container_fs_ metrics on systems with multipath devices. Without it, errors like: Failed to get disk map: open /sys/block/nvme0c0n1/dev will be logged, and cadvisor will emit nonsensical metrics with the label device="" for filesystem I/O. See google#3693 for full explanation. Signed-off-by: Craig Ringer <[email protected]>
ringerc
force-pushed
the
v0.49.0-openshift-4.17.x
branch
from
9a46813 to
cb2c0c7
Compare
Member
|
LGTM, @harche PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysfs: trim spaces in device hidden check
(cherry picked from commit 96c346e)
Backports google#3522 from cadvisor v0.51.0.
This is needed to fix container_fs_ metrics on systems with multipath devices. Without it, errors like:
will be logged, and cadvisor will emit nonsensical metrics with the label device="" for filesystem I/O.
See google#3693 for full explanation.