ai-tooling: add a claude slash command for identifying appropriate stakeholders to review an enhancement #1867
Conversation
…akeholders to review an enhancement proposal Signed-off-by: Bryce Palmer <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@everettraven: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
In other places, we are using a symlink to the Agents.md file for this, I think that should be all we need here too
| ### Review Process | ||
|
|
||
| - Authors manage the enhancement through review and approval | ||
| - Reviewers must include representatives from teams doing implementation work |
There was a problem hiding this comment.
And other teams that depend on the change/are affected by the change?
| ### Terminology | ||
| - "OpenShift" or "openshift" (NEVER "Openshift") | ||
| - Use U.S. English spelling and grammar | ||
| - Always use the Oxford comma |
| The enhancement tools require `~/.config/ocp-enhancements/config.yml`: | ||
|
|
||
| ```yaml | ||
| github: | ||
| token: "your-github-personal-access-token" | ||
| reviewers: | ||
| ignore: | ||
| - openshift-ci-robot | ||
| ``` |
There was a problem hiding this comment.
What's this? Is this something that already exists?
| ## Potential Stakeholder Reviewers for [Enhancement Name] | ||
|
|
||
| ### Primary Repository: openshift/[repo-name] | ||
| **Approvers:** |
There was a problem hiding this comment.
We generally want a single approver, does this help to pick a suitable single approver?
|
|
||
| - Enhancement reviewers should include representatives from any team that will need to do work for the enhancement | ||
| - The approver helps recognize when consensus is reached and doesn't need to be a subject-matter expert (but it helps) | ||
| - For broad-scope enhancements (changing OpenShift definition, adding required dependencies, changing customer support), a staff engineer approver is appropriate |
There was a problem hiding this comment.
I'm not sure how this tool will know who are staff engineers
2 participants
Note
This slash command, supporting documentation, and pull request description were created in collaboration with Claude Code to improve the enhancement authorship experience.
Description
Summary
Adds a /find-stakeholders slash command for Claude Code to help enhancement authors identify appropriate reviewers and approvers for their proposals.
What It Does
The /find-stakeholders command automates the process of finding the right people to review OpenShift enhancement proposals by:
When to Use It
Use this command when:
How to Use It
Simply run the command in Claude Code from the enhancements repository:
/find-stakeholders
Claude will either:
The command will then analyze the enhancement and present a report with:
Additional Changes
This PR also includes updates to AGENTS.md and CLAUDE.md to provide comprehensive repository context for Claude Code, including: