Skip to content

OCPBUGS-62836: E2E: Pass pull secret path to pull cnf-tests #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-62836: E2E: Pass pull secret path to pull cnf-tests #1402

wants to merge 1 commit into from
+14 −2

Conversation

@mrniranjan
Copy link
Contributor

At times pre pulling the cnf-tests image
fails from stage registry due to authentication
failures. This PR adds environment variable
to pass authentication details to pull the image

@mrniranjan
Pass pull secret path to pull cnf-tests
6ab3f1c 
At times pre pulling the cnf-tests image
fails from stage registry due to authentication
failures. This PR adds environment variable
to pass authentication details to pull the image

Signed-off-by: Niranjan M.R <[email protected]>
@mrniranjan mrniranjan changed the title Pass pull secret path to pull cnf-tests E2E: Pass pull secret path to pull cnf-tests Oct 2, 2025
@openshift-ci openshift-ci bot requested review from Tal-or and yanirq October 2, 2025 05:38
MarSik
MarSik approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@mrniranjan mrniranjan changed the title E2E: Pass pull secret path to pull cnf-tests OCPBUGS-62836: E2E: Pass pull secret path to pull cnf-tests Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 8, 2025
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-62836, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

At times pre pulling the cnf-tests image
fails from stage registry due to authentication
failures. This PR adds environment variable
to pass authentication details to pull the image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mrniranjan: This pull request references Jira Issue OCPBUGS-62836, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

At times pre pulling the cnf-tests image
fails from stage registry due to authentication
failures. This PR adds environment variable
to pass authentication details to pull the image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrniranjan
Copy link
Contributor Author

/retest

@mrniranjan
Copy link
Contributor Author

/verified by @mrniranjan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This PR has been marked as verified by @mrniranjan.

In response to this:

/verified by @mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrniranjan
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dbb3840 and 2 for PR HEAD 6ab3f1c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 782cd43 and 1 for PR HEAD 6ab3f1c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 186dee8 and 0 for PR HEAD 6ab3f1c in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 6ab3f1c was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2025
@mrniranjan
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tal-or Tal-or Awaiting requested review from Tal-or

@yanirq yanirq Awaiting requested review from yanirq

1 more reviewer

@MarSik MarSik MarSik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarSik MarSik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrniranjan @openshift-ci-robot @MarSik