NO-JIRA: Address false reports of bootcmdline conflicts #1371
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This significantly reduces false reports of bootcmdline conflicts in operator logs and ClusterOperator/node-tuning object. This is not a bullet-proof solution. A bullet-proof solution would involve adding a new annotation such as tuned.openshift.io/lastProfileObservedGen to the Node tied to the Profile and comparing it to the Profile's generation prior to updating a MachineConfig. However, we want to avoid putting extra load on the API server as much as possible and this simpler solution already significantly reduces false reports of bootcmdline conflicts.
jmencak
force-pushed
the
4.20-bootcmdline-conflict
branch
from
85cc657 to
e8a6d46
Compare
|
/cc @liqcui |
|
/retest |
1 similar comment
|
/retest |
|
ci/prow/e2e-gcp-pao and ci/prow/e2e-hypershift-pao will keep failing until #1374 merges. |
|
/verified by @liqcui |
openshift-ci-robot
added
the
verified
|
@liqcui: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
verified in a small size cluster, did several testing, no issue, the issue reproduced in the same small size worker nodes using 4.20 nightly version. the new pr did fix the issue |
|
/retest |
|
@jmencak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@yanirq , any chance of a review? This has already been pre-merge verified by QE and also we have support engineers asking about this. |
|
/lgtm |
jmencak
changed the title
|
@jmencak: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-merge-bot
bot
merged commit 829a37a
into
openshift:main
4 participants
This significantly reduces false reports of bootcmdline conflicts in operator logs and
ClusterOperator/node-tuningobject.This is not a bullet-proof solution. A bullet-proof solution would involve adding a new annotation such as
tuned.openshift.io/lastProfileObservedGento the Node tied to the Profile and comparing it to the Profile's generation prior to updating a MachineConfig. However, we want to avoid putting extra load on the API server as much as possible and this simpler solution already significantly reduces false reports of bootcmdline conflicts.