Skip to content

PSAP-1888: Bump vendor dependencies #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

PSAP-1888: Bump vendor dependencies #1367

merged 1 commit into from
Aug 12, 2025

Conversation

@jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 24, 2025 •
edited
Loading

Bump to k8s 1.33.3 and other vendor dependencies. Also adjust project code to reflect the vendor dependencies API changes.

@openshift-ci openshift-ci bot requested review from MarSik and swatisehgal July 24, 2025 14:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@jmencak
Copy link
Contributor Author

jmencak commented Jul 25, 2025

/test okd-scos-images
/test okd-scos-e2e-aws-ovn

@jmencak
Bump vendor dependencies
c0cdd5e 
Bump to k8s 1.33.3 and other vendor dependencies.  Also adjust project
code to reflect the vendor dependencies API changes.
@jmencak
Copy link
Contributor Author

jmencak commented Jul 28, 2025

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jul 29, 2025

CI issues
/retest

@jmencak jmencak changed the title Bump vendor dependencies PSAP-1888: Bump vendor dependencies Jul 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 29, 2025 •
edited by openshift-ci bot
Loading

@jmencak: This pull request references PSAP-1888 which is a valid jira issue.

In response to this:

Bump to k8s 1.33.3 and other vendor dependencies. Also adjust project code to reflect the vendor dependencies API changes.

This #1368 will probably need to be merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 29, 2025 •
edited by openshift-ci bot
Loading

@jmencak: This pull request references PSAP-1888 which is a valid jira issue.

In response to this:

Bump to k8s 1.33.3 and other vendor dependencies. Also adjust project code to reflect the vendor dependencies API changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 29, 2025

All tests passed, great. Last push, noticed an extra '-x' in a shell script.

@jmencak
Copy link
Contributor Author

jmencak commented Jul 29, 2025

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Jul 31, 2025

@MarSik , @swatisehgal , can I have some eye on this please? We have roughly 3 weeks to make changes to merge this. Thank you!

@MarSik
Copy link
Contributor

MarSik commented Aug 4, 2025

Looks good to me, @ffromani anything to check wrt the k8s api bumps?

swatisehgal
swatisehgal reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 1385086 and 2 for PR HEAD c0cdd5e in total

@jmencak
Copy link
Contributor Author

jmencak commented Aug 11, 2025

/retest

@jmencak
Copy link
Contributor Author

jmencak commented Aug 11, 2025

/test e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 1385086 and 2 for PR HEAD c0cdd5e in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2025

/retest-required

Remaining retests: 0 against base HEAD 1385086 and 2 for PR HEAD c0cdd5e in total

@jmencak
Copy link
Contributor Author

jmencak commented Aug 12, 2025 •
edited
Loading

/hold
Don't torture the CI, it looks like the CI will never pass, see the same failures here.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@jmencak
Copy link
Contributor Author

jmencak commented Aug 12, 2025

ci/prow/e2e-gcp-pao and ci/prow/e2e-hypershift-pao are unrelated. This is a know stalld issue. Overriding this.

/retest
/override ci/prow/e2e-gcp-pao
/override ci/prow/e2e-hypershift-pao

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao, ci/prow/e2e-hypershift-pao

In response to this:

ci/prow/e2e-gcp-pao and ci/prow/e2e-hypershift-pao are unrelated. This is a know stalld issue. Overriding this.

/retest
/override ci/prow/e2e-gcp-pao
/override ci/prow/e2e-hypershift-pao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmencak
Copy link
Contributor Author

jmencak commented Aug 12, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 96b33e1 into openshift:main Aug 12, 2025
19 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmencak jmencak deleted the 4.20-k8s-1.33.3 branch August 12, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarSik MarSik Awaiting requested review from MarSik

1 more reviewer

@swatisehgal swatisehgal swatisehgal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@swatisehgal swatisehgal

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmencak @openshift-ci-robot @MarSik @swatisehgal