- 
                Notifications
    You must be signed in to change notification settings 
- Fork 116
OCPBUGS-55399: cluster-node-tuning-operator Pod of the hosted cluster is not listening on 60000 port which makes the target to be down #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @georgelipceanu: This pull request references Jira Issue OCPBUGS-55399, which is valid. 3 validation(s) were run on this bug
 No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. | 
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: georgelipceanu The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| /retest-required | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution. I would like to explore options before to resort to just disable tls and expose the port to everyone. I'm concerned about information leaking. How can we prevent it?
b91c200    to
    4a092c2      
    Compare
  
    This is to accommodate for the change in the metrics port 60000 from HTTPS to HTTP, which allows the metrics to run without the need for additional permissions to RBAC resources in the kube-system namespace to the HyperShift operator. Signed-off-by: George Lipceanu <[email protected]>
4a092c2    to
    df3314e      
    Compare
  
    | @georgelipceanu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. | 
| Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting  If this issue is safe to close now please do so with  /lifecycle stale | 
| Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting  If this issue is safe to close now please do so with  /lifecycle rotten | 
What this PR does / why we need it:
This PR changes the NTO to run NTO related metrics on port 60000 by changing the port protocol from HTTPS to HTTP, which allows port 60000 to run in HyperShift without the need for additional permissions to RBAC resources in the kube-system namespace to the HyperShift operator.
Which issue(s) this PR fixes
Fixes #OCPBUGS-55399
Currnetly Blocking HyperShift PR