-
Notifications
You must be signed in to change notification settings - Fork 580
OCPNODE-3874: Remove the unused constant CgroupModeV1 #2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-3874: Remove the unused constant CgroupModeV1 #2579
Conversation
- cgroupv1 support has been removed from ocp > 4.19 - It is safe to remove the unused/dead constant from the code Signed-off-by: Sai Ramesh Vanka <[email protected]>
|
Pipeline controller notification For optional jobs, comment |
|
Hello @sairameshv! Some important instructions when contributing to openshift/api: |
|
@sairameshv: This pull request references OCPNODE-3874 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test verify-crd-schema |
QiWang19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Because cgroups v1 support has been removed for some time now and nowhere is relying on this constant, this seems fine to me. /lgtm @sairameshv over to you to get the verified label added. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @sairameshv |
|
@sairameshv: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
|
@sairameshv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Reference: openshift/machine-config-operator#5399 (comment)
/cc @wking