Skip to content

Conversation

@ormergi
Copy link

@ormergi ormergi commented Oct 23, 2025

This is a manual cherry-pick of #2496

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

Hello @ormergi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

@ormergi: This pull request references CORENET-6431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

This is a manual cherry-pick of #2496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2025
@ormergi ormergi changed the base branch from master to release-4.20 October 23, 2025 10:57
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

@ormergi: This pull request references CORENET-6431 which is a valid jira issue.

In response to this:

This is a manual cherry-pick of #2496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ormergi ormergi changed the title [release-4.20] CORENET-6431: Graduate user defined addrs 4.20 [release-4.20] CORENET-6431: Graduate user defined addrs Oct 23, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
@ormergi ormergi force-pushed the graduate-user-defined-addrs-4.20 branch from 9f7a6ca to b93b790 Compare October 23, 2025 10:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@JoelSpeed
Copy link
Contributor

@ormergi Feature backports require an SBAR, have you initiated that process?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phoracek
Copy link
Member

@JoelSpeed hey, we haven't yet. Will create one and get back to you

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b93b790 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify 9f7a6ca link true /test verify
ci/prow/images 9f7a6ca link true /test images
ci/prow/verify-client-go 9f7a6ca link true /test verify-client-go
ci/prow/verify-deps 9f7a6ca link true /test verify-deps
ci/prow/verify-feature-promotion 9f7a6ca link true /test verify-feature-promotion
ci/prow/verify-feature-promotion b93b790 link true /test verify-feature-promotion
ci/prow/minor-e2e-upgrade-minor 9f7a6ca link true /test minor-e2e-upgrade-minor
ci/prow/integration 9f7a6ca link true /test integration
ci/prow/verify-crdify 9f7a6ca link true /test verify-crdify
ci/prow/build 9f7a6ca link true /test build
ci/prow/e2e-aws-serial-2of2 b93b790 link true /test e2e-aws-serial-2of2
ci/prow/unit 9f7a6ca link true /test unit
ci/prow/minor-images 9f7a6ca link true /test minor-images
ci/prow/verify-crd-schema 9f7a6ca link true /test verify-crd-schema
ci/prow/lint 9f7a6ca link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants