Skip to content

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 16, 2025

Good bey old friend 👋

Follow up of #2411

/assign @JoelSpeed

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@jhadvig: This pull request references CONSOLE-4666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Good bey old friend 👋

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

Hello @jhadvig! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and spadgett October 16, 2025 12:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 16, 2025

@jhadvig: This pull request references CONSOLE-4666 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Good bey old friend 👋

Follow up of #2411

/assign @JoelSpeed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

@jhadvig Just to confirm:

  • You have something creating StorageVersionMigration in clusters, and that's been there for a few releases?
  • You have something in cluster that is removing the v1alpha1 from .status.storedVersions once the migration is complete?

@jhadvig
Copy link
Member Author

jhadvig commented Oct 20, 2025

@JoelSpeed

  1. yes - CONSOLE-3652: Create StorageVersionMigration for ConsolePlugin CRD v1 migration console-operator#816
  2. yes - OCPBUGS-44362: Remove the v1alpha1 schema for ConsolePlugin CRD #2095 but you probably mean CONSOLE-4665: Disable serving of old v1alpha1 CRD version #2411 the issue was in fact that we needed to flip the switch on the served field .

The SVM i still there and once we vendor the removal of the old API by bumping the version in the console-operator repo will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants