Skip to content

Conversation

@RomanBednar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@RomanBednar: This pull request references STOR-2297 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

Hello @RomanBednar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2025
@JoelSpeed
Copy link
Contributor

@RomanBednar When did ovirt support get removed from OCP?

@RomanBednar
Copy link
Contributor Author

@RomanBednar
Copy link
Contributor Author

RomanBednar commented Oct 13, 2025

/hold

This should be changed - instead of removal we should just add a comment about the deprecation.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@RomanBednar RomanBednar changed the title STOR-2297: remove oVirt from ClusterCSIDriver API WIP: STOR-2297: remove oVirt from ClusterCSIDriver API Oct 13, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@JoelSpeed
Copy link
Contributor

If we haven't supported oVirt since 4.14 (2 years ago), then we aren't supporting anyone upgrading to 4.21 on oVirt, so at this point, I suspect we can remove the value without breaking anyone

@RomanBednar RomanBednar changed the title WIP: STOR-2297: remove oVirt from ClusterCSIDriver API STOR-2297: remove oVirt from ClusterCSIDriver API Oct 22, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@RomanBednar
Copy link
Contributor Author

/unhold

@JoelSpeed We've discussed this a bit more and agreed that removal is fine. Is the current PR ok for this, assuming we can override the verify jobs? Seems like there are comparators to protect against accidental removals. Or do we need something different and pass the jobs?

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2025
@JoelSpeed
Copy link
Contributor

/lgtm
/override ci/prow/verify-crd-schema ci/prow/verify-crdify

We haven't supported ovirt for many releases, so removing these should be fine

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify

In response to this:

/lgtm
/override ci/prow/verify-crd-schema ci/prow/verify-crdify

We haven't supported ovirt for many releases, so removing these should be fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3a83ba5 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 3a83ba5 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-2of2 3a83ba5 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-serial-2of2 3a83ba5 link true /test e2e-aws-serial-2of2
ci/prow/e2e-azure 3a83ba5 link true /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants