-
Notifications
You must be signed in to change notification settings - Fork 576
STOR-2297: remove oVirt from ClusterCSIDriver API #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@RomanBednar: This pull request references STOR-2297 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @RomanBednar! Some important instructions when contributing to openshift/api: |
|
@RomanBednar When did ovirt support get removed from OCP? |
@JoelSpeed in 4.14 |
|
/hold This should be changed - instead of removal we should just add a comment about the deprecation. |
|
If we haven't supported oVirt since 4.14 (2 years ago), then we aren't supporting anyone upgrading to 4.21 on oVirt, so at this point, I suspect we can remove the value without breaking anyone |
|
/unhold @JoelSpeed We've discussed this a bit more and agreed that removal is fine. Is the current PR ok for this, assuming we can override the verify jobs? Seems like there are comparators to protect against accidental removals. Or do we need something different and pass the jobs? |
|
/lgtm We haven't supported ovirt for many releases, so removing these should be fine |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.