Skip to content

Conversation

@fonta-rh
Copy link

Promote DualReplica to default.

Two nodes with Fencing (DualReplica) allows deploying of a two-node OpenShift cluster with the necessary fencing tooling to prevent split-brain.

Enhancement Proposal: openshift/enhancements#1675

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

Hello @fonta-rh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

/test verify-feature-promotion

@fonta-rh
Copy link
Author

fonta-rh commented Oct 9, 2025

/test verify-feature-promotion

@fonta-rh fonta-rh marked this pull request as ready for review October 13, 2025 14:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@everettraven
Copy link
Contributor

/assign

@everettraven
Copy link
Contributor

@fonta-rh Let me know when you believe this is ready for a review. I took a quick look at the promotion verification job and it looks like there is some more runs to be gathered.

@fonta-rh
Copy link
Author

Hello @everettraven ! Yeah, we're still missing runs and % of success. I removed the draft as I don't expect any more changes on our side and wanted to make sure the rest of the CI was not hiding some trouble. We'll keep looking at this and contact you when it's passing verify-feature-promotion. Thanks!

@fonta-rh
Copy link
Author

/test verify-feature-promotion

2 similar comments
@eggfoobar
Copy link
Contributor

/test verify-feature-promotion

@eggfoobar
Copy link
Contributor

/test verify-feature-promotion

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2025

@fonta-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 9b5881e link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants