Update sparse model SageMaker doc to support sparse embedding format #4323
+55
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
zhichao-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
zhichao-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
xinyual
approved these changes
Oct 20, 2025
|
LGTM |
zane-neo
approved these changes
Oct 20, 2025
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
zhichao-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4323 +/- ##
============================================
- Coverage 80.14% 80.13% -0.01%
+ Complexity 10172 10171 -1
============================================
Files 854 854
Lines 44219 44219
Branches 5113 5113
============================================
- Hits 35440 35437 -3
- Misses 6630 6633 +3
Partials 2149 2149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhichao-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
zhichao-aws
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we've supported sparse_embedding_format for local model and parameter passing #3963 #4121 , sparse model remote endpoint should have the capability to support both embedding format. And it should be backward compatible with previous prediction request.
This PR update sparse model doc, to make sagemaker sparse model endpoint able to handle new format.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.