Use AwsV4HttpSigner instead of Aws4Signer #4102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-andy
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
rbhavna,
xinyual,
ylwu-amzn and
zane-neo
as code owners
|
Thank you for the fix! Lets apply spotless. Team can we place backport labels I would say until 2.19 would be good |
Signed-off-by: Andy Qin <[email protected]>
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Aug 13, 2025
dhrubo-os
approved these changes
Aug 13, 2025
+1 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4102 +/- ##
=========================================
Coverage 81.52% 81.52%
- Complexity 8800 8802 +2
=========================================
Files 761 761
Lines 38102 38104 +2
Branches 4248 4248
=========================================
+ Hits 31061 31066 +5
+ Misses 5196 5193 -3
Partials 1845 1845
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
q-andy
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
q-andy
added a commit
to q-andy/ml-commons
that referenced
this pull request
Aug 21, 2025
Signed-off-by: Andy Qin <[email protected]>
|
@dhrubo-os can we backport this to 3.1, 3.0, and 2.19? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Andy Qin <[email protected]> (cherry picked from commit 71d47e9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Andy Qin <[email protected]> (cherry picked from commit 71d47e9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Signed-off-by: Andy Qin <[email protected]> (cherry picked from commit 71d47e9)
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use AwsV4HttpSigner instead of Aws4Signer (deprecated)
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/auth/aws/signer/AwsV4HttpSigner.html
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/signer/Aws4Signer.html
Related Issues
Resolves #4100
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.