Skip to content

Conversation

Hailong-am
Copy link
Contributor

@Hailong-am Hailong-am commented Jul 17, 2025

Description

  1. Don't delete .plugins-ml-config index for Integration test, As the master key stores in this index, delete and recreate will cause the value in Encryptor is not consistent for encrypt and decrypt.

A exception flow may looks like

  • cluster initialized -> masterkey KeyA -> value in Encryptor is masterkey KeyA
  • IT1 run finish -> remove .plugins-ml-config index
  • IT2 start to run create a connect will use masterkey KeyA persistent in Encryptor
  • MLSyncUpJob run every 10s -> will create a new .plugins-ml-config and reset masterkey in Encryptor as KeyB
  • IT2 call predict of model use the connector which just created, the masterkey has changed to KeyB in Encryptor, so the tag mismatch exception happened.

Related Issues

#3963 (comment)
#2560

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval July 17, 2025 05:18 — with GitHub Actions Failure
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval July 17, 2025 05:18 — with GitHub Actions Failure
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval July 17, 2025 05:18 — with GitHub Actions Failure
@Hailong-am Hailong-am had a problem deploying to ml-commons-cicd-env-require-approval July 17, 2025 05:18 — with GitHub Actions Failure
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 05:57 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 05:57 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 05:57 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 05:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (0374222) to head (aafa3da).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3989      +/-   ##
============================================
+ Coverage     80.63%   80.65%   +0.02%     
- Complexity     7965     7976      +11     
============================================
  Files           694      694              
  Lines         34902    34932      +30     
  Branches       3895     3898       +3     
============================================
+ Hits          28142    28174      +32     
+ Misses         5032     5029       -3     
- Partials       1728     1729       +1     
Flag Coverage Δ
ml-commons 80.65% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 07:40 — with GitHub Actions Inactive
@Hailong-am Hailong-am temporarily deployed to ml-commons-cicd-env-require-approval July 17, 2025 07:40 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

Looks good. Thanks for fixing the issue.

@mingshl
Copy link
Collaborator

mingshl commented Jul 17, 2025

this tag mismatch flaky IT tests failure has been here for quite some time. thanks for fixing it!!!

@mingshl mingshl merged commit 90965f6 into opensearch-project:main Jul 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants