Adapt ActionFilter interface implementation to core change #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR opensearch-project/OpenSearch#18523 needs to add a new parameter to the apply() method of the ActionFilter interface. This adds the parameter to the ActionFilter implementations. Signed-off-by: Nils Bandener <[email protected]>
nibix
requested review from
Hailong-am,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
Hailong-am
approved these changes
Oct 25, 2025
Collaborator
|
please check the complie error |
Author
|
The error occurs because index-management still uses OpenSearch core in version |
Author
|
Note: Merging #1499 should unblock this |
Member
|
@nibix wdyt about doing the version bump within this PR since the changes need to go simultaneously for the checks to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The core PR opensearch-project/OpenSearch#18523 has changed the
ActionFilterinterface by adding a newapply()method with an additional parameter. The oldapply()method is now deprecated. This change adds the parameter to the ActionFilter implementations.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.