Skip to content

Redeclare variables in new blocks when running MinimumSwitchCases #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Redeclare variables in new blocks when running MinimumSwitchCases #689

wants to merge 4 commits into from

Conversation

Jenson3210
Copy link
Contributor

What's changed?

By storing (reducing) the variables declared in the first block, we can see that the usages in the second block not refer to them. By using map.remove we make sure that we only replace the first statement in the second block (if any)

What's your motivation?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Jenson3210 Jenson3210 self-assigned this Aug 5, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Aug 5, 2025
@Jenson3210 Jenson3210 added the bug Something isn't working label Aug 5, 2025
@Jenson3210 Jenson3210 changed the title Fixed the provided failing test Redeclare variables in new blocks when running MinimumSwitchCases Aug 5, 2025
github-actions[bot]
github-actions bot reviewed Aug 5, 2025
View reviewed changes
Jenson3210 and others added 2 commits August 5, 2025 12:39
@Jenson3210 @github-actions
Update src/main/java/org/openrewrite/staticanalysis/MinimumSwitchCase…
55e7840 
…s.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Jenson3210
Fixed the provided failing test
ca643b8 
Fixes #687
@Jenson3210 Jenson3210 moved this from In Progress to Ready to Review in OpenRewrite Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@jevanlingen jevanlingen jevanlingen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Jenson3210 Jenson3210

Labels
bug Something isn't working
Projects
OpenRewrite
Status: Ready to Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MinimumSwitchCases does not redeclare variables in new blocks
2 participants
@Jenson3210 @jevanlingen