-
Notifications
You must be signed in to change notification settings - Fork 109
Description
What problem are you trying to solve?
Spring Framework 6.1 made this change: https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-6.x?secureweb=Teams#parameter-name-retention
Looking at the discussion behind that change (spring-projects/spring-framework#29531), it seems that the Spring Team expects that ~all Spring Framework apps are using the -parameters option already, by convention. And now in 6.1, many features break if the project is not using that compiler option.
What precondition(s) should be checked before applying this recipe?
- Check that project is not using Spring Boot Starter Parent as a Maven Parent (or similar for Gradle), as this applies the relevant
-parametersconfig already- Maybe transitively check the parent hierarchy for anything setting the
-parametersoption instead of hardcoding spring-boot-starter-parent
- Maybe transitively check the parent hierarchy for anything setting the
- Check that the project doesn't already set
-parametersin its own config
Describe the situation before applying the recipe
Describe the situation after applying the recipe
See the examples in the Spring Release Notes up above
Have you considered any alternatives or workarounds?
A collection of recipes could attempt to tweak source code to avoid using every feature which relies on parameter names (eg always explicitly give the name in every @PathVariable), but this would be a large scope and seems inconsistent with Spring conventions.
Any additional context
Are you interested in contributing this recipe to OpenRewrite?
Maybe; probably not in the short term
Metadata
Metadata
Assignees
Labels
Type
Projects
Status